feat: make interaction point cut optional in seedFinder #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
approved these changes
Mar 25, 2022
stephenswat
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 47.75% 47.74% -0.01%
==========================================
Files 360 360
Lines 18616 18618 +2
Branches 8774 8776 +2
==========================================
Hits 8890 8890
- Misses 3674 3676 +2
Partials 6052 6052
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
fix format in python and this goes in |
|
Format job is broken see #1212. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
Cut on the maximum allowed curvature considering two SPs only. This is the same cut as #1207 in `SeedFinder`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cut on the compatibility between the SP and the interaction point was added to the seedFinder in PR #1084
The cut may not always be necessary or wanted so this PR makes the cut optional by introducing a boolean
interactionPointCutThis is also useful for the ITk implementation because this cut is used for the pixel SPs but not for the strip SPs