fix: Require Python version ≥3.8 for examples #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, we import Python when building the Python bindings, but we do not require it at configuration time, and we do not specify a minimum version. In practice, the examples do not work with Python versions lower than 3.8. This commit, therefore, makes the Python package required in the CMake build system, and requires version 3.8 or higher.
stephenswat
changed the title
stephenswat
added
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 381 381
Lines 20785 20785
Branches 9536 9536
=======================================
Hits 10090 10090
Misses 4112 4112
Partials 6583 6583 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AJPfleger
approved these changes
Oct 18, 2022
|
Generally fine, the reality is that it needs to be whatever ROOT was compiled against. |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Oct 20, 2022
As it stands, we import Python when building the Python bindings, but we do not require it at configuration time, and we do not specify a minimum version. In practice, the examples do not work with Python versions lower than 3.8. This commit, therefore, makes the Python package required in the CMake build system, and requires version 3.8 or higher.
paulgessinger
pushed a commit
that referenced
this pull request
Oct 20, 2022
As it stands, we import Python when building the Python bindings, but we do not require it at configuration time, and we do not specify a minimum version. In practice, the examples do not work with Python versions lower than 3.8. This commit, therefore, makes the Python package required in the CMake build system, and requires version 3.8 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, we import Python when building the Python bindings, but we do not require it at configuration time, and we do not specify a minimum version. In practice, the examples do not work with Python versions lower than 3.8. This commit, therefore, makes the Python package required in the CMake build system, and requires version 3.8 or higher.