Skip to content

Commit

Permalink
fix: Require Python version ≥3.8 for examples (#1602)
Browse files Browse the repository at this point in the history
As it stands, we import Python when building the Python bindings, but we do not require it at configuration time, and we do not specify a minimum version. In practice, the examples do not work with Python versions lower than 3.8. This commit, therefore, makes the Python package required in the CMake build system, and requires version 3.8 or higher.
  • Loading branch information
stephenswat authored Oct 18, 2022
1 parent 9c780d4 commit b18804a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ endmacro()
# when a particular package is actually needed.
# plugin dependencies
if(ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS)
find_package(Python COMPONENTS Interpreter Development)
find_package(Python 3.8 REQUIRED COMPONENTS Interpreter Development)
if(ACTS_USE_SYSTEM_PYBIND11)
find_package(pybind11 CONFIG REQUIRED)
else()
Expand Down

0 comments on commit b18804a

Please sign in to comment.