Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@actions/artifact 0.5.1 release #760

Merged
merged 2 commits into from
Apr 6, 2021
Merged

@actions/artifact 0.5.1 release #760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776b857
Bump @actions/http-client to latest for artifact package
konradpabjan Apr 5, 2021
2790eef
Remove typescript libs to fix failing imports
konradpabjan Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/artifact/RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,7 @@

- Improved retry-ability for all http calls during artifact upload and download if an error is encountered

### 0.5.1

- Bump @actions/http-client to version 1.0.11 to fix proxy related issues during artifact upload and download

6 changes: 3 additions & 3 deletions packages/artifact/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/artifact/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"dependencies": {
"@actions/core": "^1.2.6",
"@actions/http-client": "^1.0.7",
"@actions/http-client": "^1.0.11",
"@types/tmp": "^0.1.0",
"tmp": "^0.1.0",
"tmp-promise": "^2.0.2"
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"declaration": true,
"target": "es6",
"sourceMap": true,
"lib": ["es6"]
"lib": ["es6","dom"]
Copy link
Contributor Author

@konradpabjan konradpabjan Apr 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though this would be a normal update, but doing npm install @actions/[email protected] starts failing while doing tsc. The issue appears to have originated while going from 1.0.8 to 1.0.9

image

The artifact packages imports HttpCodes, HttpClient, BearerCredentialHandler and IHttpClientResponse from the @action/http-client package so nothing out of the ordinary.

I found this solution, and I think is the best course of action: https://stackoverflow.com/questions/42603783/missing-basic-dom-types-in-typescript-project

More information about the "dom" lib here: https://www.typescriptlang.org/tsconfig#lib

Copy link
Contributor

@brcrista brcrista Apr 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DOM URL is different from Node URL. We have v12 of @types/node installed; I wonder why it's not picking that up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this issue by just removing "lib": ["es6"] completely from tsconfig. I had to make a small tweak in @actions/exec but other than that @actions/http-client does the same thing: https://github.com/actions/http-client/blob/main/tsconfig.json

},
"exclude": [
"node_modules",
Expand Down