-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@actions/artifact 0.5.1 release #760
Conversation
tsconfig.json
Outdated
@@ -6,7 +6,7 @@ | |||
"declaration": true, | |||
"target": "es6", | |||
"sourceMap": true, | |||
"lib": ["es6"] | |||
"lib": ["es6","dom"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though this would be a normal update, but doing npm install @actions/[email protected]
starts failing while doing tsc
. The issue appears to have originated while going from 1.0.8
to 1.0.9
The artifact packages imports HttpCodes
, HttpClient
, BearerCredentialHandler
and IHttpClientResponse
from the @action/http-client
package so nothing out of the ordinary.
I found this solution, and I think is the best course of action: https://stackoverflow.com/questions/42603783/missing-basic-dom-types-in-typescript-project
More information about the "dom" lib here: https://www.typescriptlang.org/tsconfig#lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this issue by just removing "lib": ["es6"]
completely from tsconfig
. I had to make a small tweak in @actions/exec
but other than that @actions/http-client
does the same thing: https://github.com/actions/http-client/blob/main/tsconfig.json
* Bump @actions/http-client to latest for artifact package * Remove typescript libs to fix failing imports
Bump
@actions/http-client
to the latest version and create a new release fix a proxy related issue that is effecting some larger enterprise customers: actions/http-client#42