Use posix archive format #533
Conversation
smorimoto
force-pushed
the
posix-archive-format
branch
from
2657240
to
ca5af8e
Compare
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
posix-archive-format
branch
from
ca5af8e
to
2de8727
Compare
|
@aiqiaoy This should now be in a mergeable state. Could you review it? |
|
CC: @joshmgross |
|
Related issue: actions/cache#326 |
There was a problem hiding this comment.
Just a small request to change the package version to 1.0.2 in all the places. Overall looks good! Thanks for submitting this PR ❤️
CC @aiqiaoy
| @@ -101,6 +101,7 @@ export async function createTar( | |||
| } | |||
| } | |||
| const args = [ | |||
| '--posix', | |||
There was a problem hiding this comment.
I looked over the previous PR, I think this won't cause any compat issues. No objections from me 👍
There was a problem hiding this comment.
Yeah, this shouldn't cause any problems.
smorimoto
force-pushed
the
posix-archive-format
branch
from
1b2a3cd
to
7737589
Compare
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
posix-archive-format
branch
from
7737589
to
3be5c33
Compare
|
@konradpabjan Thanks for your review. |
|
Yeah sorry I was on-call when I reviewed the original PR and completely forgot about following up. Looks good! |
|
Version |
|
@konradpabjan Thanks again for your work :) |
|
@aiqiaoy No worries! I sometimes do something similar to you. |
See #475 for details.
Closes: actions/cache#326