Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use posix archive format #475

Closed
wants to merge 1 commit into from
Closed

Use posix archive format #475

wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented May 26, 2020

Related issue: actions/cache#326

@smorimoto
Copy link
Contributor Author

I've checked that this works on my Windows machine, so there should be no major problem.

JosephDuffy added a commit to JosephDuffy/actions-playground that referenced this pull request Jun 2, 2020
https://bugs.swift.org/browse/SR-11760 might be caused by the loss of fractional timestamps. actions/toolkit#475 should store fractional timestamps as part of the cache, but has not been merged yet.

I expect the cache to not reduce the runtime currently.
JosephDuffy added a commit to JosephDuffy/actions-playground that referenced this pull request Jun 2, 2020
https://bugs.swift.org/browse/SR-11760 might be caused by the loss of fractional timestamps. actions/toolkit#475 should store fractional timestamps as part of the cache, but has not been merged yet.

I expect the cache to not reduce the runtime currently.
JosephDuffy added a commit to JosephDuffy/actions-playground that referenced this pull request Jun 2, 2020
https://bugs.swift.org/browse/SR-11760 might be caused by the loss of fractional timestamps. actions/toolkit#475 should store fractional timestamps as part of the cache, but has not been merged yet.

I expect the cache to not reduce the runtime currently.
@smorimoto
Copy link
Contributor Author

@joshmgross @aiqiaoy friendly ping

@smorimoto
Copy link
Contributor Author

Updated.

@smorimoto
Copy link
Contributor Author

Status?

@smorimoto
Copy link
Contributor Author

Hi @bryanmacfarlane. Can you check this?

@smorimoto
Copy link
Contributor Author

If necessary, please let me know so that I can help you with the maintenance of the cache action related projects.

@joshmgross joshmgross requested a review from aiqiaoy July 16, 2020 23:47
@aiqiaoy aiqiaoy changed the base branch from master to main July 20, 2020 14:32
@aiqiaoy aiqiaoy changed the base branch from main to master July 20, 2020 14:48
Copy link
Contributor

@aiqiaoy aiqiaoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smorimoto Change looks good but please bump the minor package version here and update releases.md

Example PR here

@aiqiaoy
Copy link
Contributor

aiqiaoy commented Jul 20, 2020

I pulled the branch and tested on my mac (mac and linux runner is using zstd tar). Everything looks good.

@smorimoto
Copy link
Contributor Author

Sorry. I will be in an area with an unstable Internet connection until the 29th. Of course, I can work on this later. But, if you don't mind, this branch is set to be editable by you, so feel free to push those changes.

@smorimoto
Copy link
Contributor Author

I lost the repository because of an accident, so I will close this and open another PR later.

@smorimoto
Copy link
Contributor Author

This was merged as #533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants