[@actions/attest] Fix bug with customized OIDC issuer #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
force-pushed
the
bdehamer/enterprise-issuer
branch
2 times, most recently
from
6b20780 to
6eb1f30
Compare
bdehamer
commented
Sep 4, 2024
| audience: OIDC_AUDIENCE, | ||
| issuer | ||
| audience: OIDC_AUDIENCE |
There was a problem hiding this comment.
The jose library only checks for absolute matches, so we're going to remove the check of the iss claim and implement our own regex-based check.
bdehamer
force-pushed
the
bdehamer/enterprise-issuer
branch
from
6eb1f30 to
5bc3bcc
Compare
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/enterprise-issuer
branch
from
5bc3bcc to
2a07de1
Compare
kommendorkapten
approved these changes
Sep 5, 2024
Cinderella252
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when generating provenance statements for enterprise accounts using customized OIDC issuer value.
Previously, there was a strict comparison of the
issclaim in the OIDC token to ensure that it originated from the GitHub Actions provider. However, this did not account for the fact that enterprise accounts may append their enterprise slug to the end of the standard issuer URL.The comparison has been updated to check that the issuer URL starts with a value that matches the GitHub provider.
See: actions/attest-build-provenance#222