Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customized issuer values for GitHub Enterprise Cloud #222

Closed
isometry opened this issue Sep 3, 2024 · 2 comments
Closed

Support customized issuer values for GitHub Enterprise Cloud #222

isometry opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@isometry
Copy link

isometry commented Sep 3, 2024

The action is currently incompatible with any organisation belonging to a GitHub Enterprise Cloud instance that has followed the hardening guidance to customize the issuer value:

Error: Failed to get ID token: unexpected "iss" claim value

With the GitHub Actions OIDC Custom Issuer Policy enabled (i.e. include_enterprise_slug=true), the Enterprise Cloud issuer becomes https://token.actions.githubusercontent.com/${enterpriseSlug}.

Ideally, the action would dynamically retrieve the correct enterpriseSlug given the runtime context; alternatively it should support an optional enterpriseSlug input parameter to be suffixed to the calculated issuer.

@bdehamer bdehamer self-assigned this Sep 3, 2024
@bdehamer bdehamer added the bug Something isn't working label Sep 3, 2024
@bdehamer
Copy link
Collaborator

bdehamer commented Sep 3, 2024

Definitely something we need to fix.

I don't think there is a good way to determine whether the issuer customization is enabled for a given account, so will probably end-up with an include_enterprise_slug input param.

@bdehamer
Copy link
Collaborator

bdehamer commented Sep 5, 2024

This should be resolved with the v1.4.3 release. We didn't end-up adding a new input parameter -- it should just work whether or not you have customized the issuer URL for your organization.

@bdehamer bdehamer closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants