-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't remove registry unless it is assigned #118
Comments
Looking at this article, I think I'm hitting the same issue here where I need to set the npmrc in that pattern for proxying to npm to work. |
Hello @joebowbeer. Thank you for your report. The setup-node action supports only scoped registry for GitHub packages. If the scope is not provided the action sets the scope automatically for GitHub package registry. I think the action should remove registry line because the .npmrc file can contain any amount of scoped registries but it's limited by common registries. |
@dmitry-shibanov Where is the updated documentation for setup-node with registry-url? This issue is reporting that it is a bug for setup-node to remove the default registry for non-scoped dependencies, as discussed in #87 It is also requesting that the documentation explain when setup-node may remove lines from the .npmrc file. By the way, I think there is some confusion in terminology. You refer to the following as a common registry?
|
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Given that: If registry-url is specified then a
@scope:registry=
line will always be added to .npmrc if the registry is npm.pkg.github.com,I think it's a bug for setup-node to remove the
registry=
line from .npmrc. In theory this line could be configuring a registry that is totally unrelated to GitHub packages.In short, setup-node should only remove lines it is replacing.
In addition, I think better doc is needed regarding the use of the
https://npm.pkg.github.com/owner
proxy registry. Is setup-node compatible with the proxy registry? Or should an explicitly scoped registry always be used?The text was updated successfully, but these errors were encountered: