Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped registries are duplicated #615

Closed
2 of 5 tasks
AlexMeah opened this issue Oct 27, 2022 · 2 comments
Closed
2 of 5 tasks

Scoped registries are duplicated #615

AlexMeah opened this issue Oct 27, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AlexMeah
Copy link

AlexMeah commented Oct 27, 2022

Description:

When scope is specified and a matching scoped registry exists in .npmrc the registry entry is duplicated.

Action version:
3.4.1

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
Node 14
NPM 6

Repro steps:
Add an .npmrc with @scope:registry=https://example.com/ and an action with registry: https://example2.com and scope: scope.

Expected behavior:
The scoped registry should be overwritten by the action config.

Actual behavior:
The registry is duplicated and the first entry takes precedence.

Related issues: #118, #87

PR: #616

@AlexMeah AlexMeah added bug Something isn't working needs triage labels Oct 27, 2022
@AlexMeah AlexMeah mentioned this issue Oct 27, 2022
2 tasks
@dmitry-shibanov
Copy link
Contributor

Hello @AlexMeah. Thank you for your report. We'll investigate the issue.

@dsame
Copy link
Contributor

dsame commented Dec 6, 2022

Hello @AlexMeah i am closing the issue with this PR
#637

Feel free to reopen it or create another one in case if the problem still exists

@dsame dsame closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants