Use install-dotnet scripts for installation #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
November 5, 2019 10:02
Tests should not concern internal workings of install-dotnet as those are covered by the appropriate repo and team.
ZEisinger
commented
Feb 7, 2020
| // Fallback to \n if initial split doesn't work (not consistent across versions) | ||
| if (lines.length === 1) { | ||
| lines = output.split('\n'); | ||
| let scriptArguments: string[] = []; |
There was a problem hiding this comment.
Need to pass proxy settings into the script when being called
ZEisinger
commented
Feb 7, 2020
src/installer.ts
Outdated
| .replace(/'/g, "''"); | ||
| let command = `& '${escapedScript}'`; | ||
| if (this.version) { | ||
| command += ` -Version ${this.version}`; |
There was a problem hiding this comment.
Need to pass in proxy settings
|
Any updates on this? |
|
@RehanSaeed I’ve been using for a while now. I know it’s not the best solution but you’re able to use this by referencing the branch name whole this gets merged. |
added 3 commits
April 14, 2020 14:14
|
The install scripts are incompatible with proxy settings added recently. The product team has also pushed back on autoupgrade scenarios being added. Addressing #25 will need to be done separately. |
added 6 commits
July 16, 2020 15:13
bekir-ozturk
added a commit
to dotnet/install-scripts
that referenced
this pull request
Jul 29, 2020
Required for actions/setup-dotnet#71. Agents can set proxy settings for their runs which include addresses which should not go through the proxy. This script doesn't allow that value to be specified for windows. In the shell script this is handled by wget and curl both honoring the environment variables https_proxy and no_proxy.
ZEisinger
force-pushed
the
sxs-with-fallback
branch
from
6190d3b to
b7f3cf0
Compare
added 2 commits
August 10, 2020 12:00
|
Is this now released? |
@RehanSaeed Looks like a new PR was created for side by side installs #124 |
|
There were a lot of changes since this PR, so I created a clean PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sxs issues (#25), caching, allows using global.json (#14), better error messages (#54)
Default install location is used rather than the toolkit's cache, this enables side by side installs to work properly.