Install sxs with the install-dotnet scripts #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ jobs: | |||
| build: | |||
| runs-on: ${{ matrix.operating-system }} | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Curious question: What does fail-fast do?
There was a problem hiding this comment.
When fail-fast is true the other jobs in the matrix are immediately cancelled when one of the job fails. So when the MacOS job fails, the Windows job (which typically takes longer) is immediately cancelled and potentially hides different errors.
StanleyGoldman
approved these changes
Sep 15, 2020
|
Docs should be updated to include an sxs example. |
|
@jetersen Thanks for calling this out, I've added an example to README: https://github.com/actions/setup-dotnet#usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25
Using the install-dotnet scripts to inside in default global location to enable SxS builds and to use cached versions on hosted agents by default. Install-dotnet.ps1 script has been updated to support proxy setting requirements.