This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Fix the broken downloading (hopefully) #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next steps are get the target from a matrix instead of copying it in again and some docs tweaks |
kaimen-sano
reviewed
Feb 17, 2023
| @@ -52,6 +53,7 @@ See [additional recipes here](https://github.com/actions-rs/meta). | |||
| | Name | Required | Description | Type | Default | | |||
| | ------------| :------: | ---------------------------------------------------------------------------------------------------------| ------ | --------| | |||
| | `version` | | The version of `cargo-tarpaulin` that will be installed. | string | latest | | |||
| | `target` | ✓ | The target to install tarpaulin for i.e. `x86_64-unknown-linux-gnu`. | string | latest | | |||
There was a problem hiding this comment.
Probably shouldn't include the Default field here (leaving it empty instead).
kaimen-sano
reviewed
Feb 17, 2023
| const asset = releaseInfo["assets"].find(asset => { | ||
| return asset['content_type'] === 'application/gzip'; | ||
|
|
||
| const asset = releaseInfo["name"].find(asset => { |
There was a problem hiding this comment.
This should still refer to releaseInfo["assets"]
This was referenced Mar 7, 2023
Closed
|
any ETA on this ? |
dlaehnemann
added a commit
to rust-bio/rust-htslib
that referenced
this pull request
Jun 20, 2023
…paulin#23 It seems like the download is broken in the `actions-rs/tarpaulin` GitHub Action for all tarpaulin versions above `0.22.0`. See this pending fix for details: actions-rs/tarpaulin#23
johanneskoester
pushed a commit
to rust-bio/rust-htslib
that referenced
this pull request
Jun 20, 2023
* update tarpaulin used in CI to latest available version * fix: try including `--doc --examples` in tarpaulin arguments, to include coverage by doctests and code examples * revert back to 0.22.0 until tarpaulin action is fixed: actions-rs/tarpaulin#23 It seems like the download is broken in the `actions-rs/tarpaulin` GitHub Action for all tarpaulin versions above `0.22.0`. See this pending fix for details: actions-rs/tarpaulin#23 * try with the nightly toolchain for code coverage of doctests * document in-code the current problem with artefact download blocking tarpaulin update * try with `--run-types Tests,Doctests` for full coverage: xd009642/tarpaulin#538
epsilonhalbe
added a commit
to epsilonhalbe/obsidian-export
that referenced
this pull request
Sep 17, 2023
tarpaulin releases multiple artifacts since version 0.24.0, this somehow breaks the download bit of the github action. fixing the version to 0.22.0 is a temporary solution until actions-rs/tarpaulin#23 is merged
3 tasks
tomaszklak
added a commit
to NordSecurity/libtelio
that referenced
this pull request
Oct 4, 2023
This is a port from previous version of CI and uses the same command as previously. There might seem to be multiple other and better ways to do it but they are all broken in some ways. We could use the action https://github.com/actions-rs/tarpaulin but that one is no longer maintained. The last version of tarpaulin it works with is 0.22 from October 2022 and the fix is still not merged in after multiple months: actions-rs/tarpaulin#23 . Additionally there are discussions to deprecate this action: actions-rs/tarpaulin#6 Alternatively we could have used the 'official' docker image of tarpaulin: https://hub.docker.com/r/xd009642/tarpaulin . This will not work since when github action runs in a docker, the container is not started with enough privileges which causes tarpaulin to crash, see as an example of this here: xd009642/tarpaulin#146
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tarpaulin now has release artefacts for mac (which appear first in the list when I queried) and the github API is returning tar.gz content type as
application/x-gtarthis action has been broken for some time. This PR attempts to fix it - however I don't do typescript and haven't figured out a way to test it yet.As an aside a number of people have been contacting me directly about this action being broken, and not being a contributor to this repo I'm not able push out a fix myself - merely recommend alternatives. I'd appreciate it if I could be added as a contributor - or if the project is deprecated if that could be made clear (i.e. big bold text in the readme and archive the project).