Add tarpaulin based code coverage job #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszklak
force-pushed
the
LLT-4043-code-coverage
branch
from
0026eed to
e559119
Compare
packgron
previously approved these changes
Oct 4, 2023
tomaszklak
force-pushed
the
LLT-4043-code-coverage
branch
from
e559119 to
65aba2e
Compare
This is a port from previous version of CI and uses the same command as previously. There might seem to be multiple other and better ways to do it but they are all broken in some ways. We could use the action https://github.com/actions-rs/tarpaulin but that one is no longer maintained. The last version of tarpaulin it works with is 0.22 from October 2022 and the fix is still not merged in after multiple months: actions-rs/tarpaulin#23 . Additionally there are discussions to deprecate this action: actions-rs/tarpaulin#6 Alternatively we could have used the 'official' docker image of tarpaulin: https://hub.docker.com/r/xd009642/tarpaulin . This will not work since when github action runs in a docker, the container is not started with enough privileges which causes tarpaulin to crash, see as an example of this here: xd009642/tarpaulin#146
tomaszklak
force-pushed
the
LLT-4043-code-coverage
branch
from
65aba2e to
11f0fec
Compare
packgron
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port from previous version of CI and uses the same command as previously.
There might seem to be multiple other and better ways to do it but they are all broken in some ways.
We could use the action https://github.com/actions-rs/tarpaulin but that one is no longer maintained. The last version of tarpaulin it works with is 0.22 from October 2022 and the fix is still not merged in after multiple months: actions-rs/tarpaulin#23 . Additionally there are discussions to deprecate this action: actions-rs/tarpaulin#6
Alternatively we could have used the 'official' docker image of tarpaulin: https://hub.docker.com/r/xd009642/tarpaulin . This will not work since when github action runs in a docker, the container is not started with enough privileges which causes tarpaulin to crash, see as an example of this here:
xd009642/tarpaulin#146
☑️ Definition of Done checklist