Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appropriate field for the form control #1387

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Update appropriate field for the form control #1387

merged 9 commits into from
Jul 21, 2020

Conversation

ajanec01
Copy link
Collaborator

Re-wording the definition of Appropriate field for the form control so that it references required control groups/ input states.

Closes issue #1366

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ajanec01 ajanec01 added Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted labels Jul 10, 2020
@ajanec01 ajanec01 mentioned this pull request Jul 10, 2020
Closed
@ajanec01
Update aria-required-owned-element-bc4a75.md
5aebe48 
Cleaning up- made a pull from a local branch with other pr.
carlosapaduarte
carlosapaduarte approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial suggestions. Feel free to ignore.
While you're at it, I believe you could move even more notes to the background section ;-)

pages/glossary/appropriate-field-for-the-form-control.md Outdated Show resolved Hide resolved
_rules/aria-required-owned-element-bc4a75.md Outdated Show resolved Hide resolved
@ajanec01 ajanec01 requested a review from Jym77 July 20, 2020 08:06
@ajanec01 ajanec01 merged commit 49d0c44 into develop Jul 21, 2020
@ajanec01 ajanec01 deleted the update-control-group branch July 21, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy Awaiting requested review from jeeyyy

@adilsofficial adilsofficial Awaiting requested review from adilsofficial

Assignees
No one assigned
Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajanec01 @CLAassistant @WilcoFiers @carlosapaduarte @Jym77