Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete field name needs an appropriate control group (#73f2c2) #1366

Closed
ajanec01 opened this issue Jul 3, 2020 · 4 comments
Closed
Assignees

Comments

@ajanec01
Copy link
Collaborator

ajanec01 commented Jul 3, 2020

I've just noticed that the autocomplete attribute has valid value rule does not mention that the autocomplete field name needs an appropriate control group, i.e. Field name: "bday-day" needs "numeric" control group.

Do you think it's worth adding a note?

@WilcoFiers
Copy link
Member

If I understand what you're suggesting, this should be covered by expectation 3. Can you clarify maybe why you think it may not be, or why it may not be clear enough?

@ajanec01
Copy link
Collaborator Author

ajanec01 commented Jul 6, 2020

The suggestion is to re-word the definition of appropriate autocomplete field to say that each autocomplete field name is applicable to input elements with a limited number of states.

As it stands, the definition goes: "The field name listed in the autocomplete fields table from the HTML 5.2 specification is used in the autocomplete attribute of an element: https://html.spec.whatwg.org/#inappropriate-for-the-control"

The way I read it is: The field name from the table is used in the autocomplete attribute.

Maybe it's only me but I think the definition could go: "The field name listed in the autocomplete fields table from the HTML 5.2 specification (https://html.spec.whatwg.org/#inappropriate-for-the-control) is appropriate if the form control it applies to belongs to the specified control group".

I know that the examples cover it, I just don't think it is that clear.

@WilcoFiers
Copy link
Member

Sounds good to me. Would you like to put together a pull request?

@ajanec01
Copy link
Collaborator Author

Sure! PR #1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants