Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix issues discovered by validation #163

Merged
merged 2 commits into from
Nov 22, 2024

feat: fix issues discovered by validation

f39d665
Select commit
Loading
Failed to load commit list.
Merged

feat: fix issues discovered by validation #163

feat: fix issues discovered by validation
f39d665
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 1s

72.55% (-0.85%) compared to 21b5fe5

View this Pull Request on Codecov

72.55% (-0.85%) compared to 21b5fe5

Details

Codecov Report

Attention: Patch coverage is 54.74453% with 62 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (21b5fe5) to head (f39d665).

Files with missing lines Patch % Lines
sk-cli/src/validation/summary.rs 0.00% 19 Missing ⚠️
sk-cli/src/validation/validation_store.rs 70.27% 11 Missing ⚠️
sk-cli/src/validation/mod.rs 0.00% 10 Missing ⚠️
sk-store/src/store.rs 16.66% 10 Missing ⚠️
sk-cli/src/validation/annotated_trace.rs 86.66% 6 Missing ⚠️
sk-cli/src/validation/status_field_populated.rs 25.00% 3 Missing ⚠️
sk-cli/src/xray/app.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   73.39%   72.55%   -0.85%     
==========================================
  Files          54       55       +1     
  Lines        2808     2911     +103     
==========================================
+ Hits         2061     2112      +51     
- Misses        747      799      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov