Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix issues discovered by validation #163

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Nov 21, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Fix issues discovered by skctl validation

Testing done

  • Manual testing on a trace file
  • test apply patch, validation fixes

@drmorr0 drmorr0 force-pushed the drmorr/apply-validation-fixes branch from 2ebdc19 to c4dfd3c Compare November 21, 2024 23:11
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 54.74453% with 62 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (21b5fe5) to head (f39d665).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sk-cli/src/validation/summary.rs 0.00% 19 Missing ⚠️
sk-cli/src/validation/validation_store.rs 70.27% 11 Missing ⚠️
sk-cli/src/validation/mod.rs 0.00% 10 Missing ⚠️
sk-store/src/store.rs 16.66% 10 Missing ⚠️
sk-cli/src/validation/annotated_trace.rs 86.66% 6 Missing ⚠️
sk-cli/src/validation/status_field_populated.rs 25.00% 3 Missing ⚠️
sk-cli/src/xray/app.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   73.39%   72.55%   -0.85%     
==========================================
  Files          54       55       +1     
  Lines        2808     2911     +103     
==========================================
+ Hits         2061     2112      +51     
- Misses        747      799      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@drmorr0 drmorr0 force-pushed the drmorr/apply-validation-fixes branch from c4dfd3c to 6462b03 Compare November 22, 2024 06:00
@drmorr0 drmorr0 force-pushed the drmorr/apply-validation-fixes branch from 6462b03 to f39d665 Compare November 22, 2024 22:41
@drmorr0 drmorr0 merged commit 322cb22 into master Nov 22, 2024
7 of 8 checks passed
@drmorr0 drmorr0 deleted the drmorr/apply-validation-fixes branch November 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant