-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connects to #965: Add --config-dir option to Drush site-install command. #966
Conversation
@geerlingguy just FYI, you need to use one of the following keywords to "connect" an issue in GitHub to another: close E.g., "Fixes #965" rather than "Issue #965" See https://help.github.com/articles/closing-issues-via-commit-messages/ |
Error is:
Hmm... so our automated tests would only work if you have at least a tiny bit of config exported. |
@geerlingguy Re:keywords. Fair enough. In that case, let's use Waffle.io's keywords so that issues are visually connected on our Kanban board: connect to |
We have a kanban board?? |
@grasmash - I updated the commit message at least—haven't looked into making Travis happy. |
|
@grasmash - Yeah... not sure how to deal with that—this is necessary after you've done your first config dump, but it doesn't work until that's been done. Chicken and egg issue. Maybe we can have a flag/if/else thing that can say "enable this in the build" and have it off by default? |
I think this is basically a duplicate of #884 |
@grasmash - Yeah, basically. It would be nice if we had a flag that you could set to enable this option once the project is up and running—and only if you choose to use full CMI (and not |
That would also allow us to default to the current behavior, which can pass tests here in Travis since there isn't any config to kick off a brand new site/project. |
…uration directory and partial flag to be configurable.
Closing since #1080 got in. |
Relates to Issue #965.
Changes proposed:
--config-dir
option to Drushsite-install
command.Note: This should be tested on sites that are currently not using full CMI export/import to make sure nothing is broken in the build in that situation.