Don't force the config directory to be "vcs" during deploys #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with making the config directory configurable here, but I don't think we can remove it because deployments to ACE will start failing. On ACE it does need to be |
|
Hmm yeah I understand. Don't want an unexpected change to break deployments. Note that I'm just removing the property override here. The I wonder how people on ACE handle the annoyance of having two config directories defined. I don't think Acquia should have defined this 'vcs' directory in their config file to begin with. |
|
Apparently you're not the only one :) |
grasmash
added a commit
to grasmash/bolt
that referenced
this pull request
Feb 13, 2017
…uration directory and partial flag to be configurable.
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1013