Updating settings command. #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpagini
commented
Jul 8, 2017
| $copy_map[$project_default_settings_file] = $project_settings_file; | ||
| } | ||
| else { | ||
| $this->yell("No $default_project_default_settings_file file found."); |
There was a problem hiding this comment.
I added this "yell" just to make sure the user is aware that an expected file is missing.
There was a problem hiding this comment.
I'd prefer to use $this->logger>warning() rather than $this->yell().
There was a problem hiding this comment.
Sure thing, let me make that update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands changes made in #1765.
If
docroot/sites/default/default.settings.phpdoes not exist, don't try to copy it to the current multisitedefault.settings.php, and also don't try to copy it to current multisitesettings.php.