Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
docroot/sites/$multisite/default.settings.php
exists before it tries to copy that file todocroot/sites/$multisite/settings.php
Reasoning...
In my multisite, I like to keep a single copy of Drupal's
default.settings.php
file. We keep it indocroot/sites/all/
and have it copied there via composer and drupal-scaffold (see below). I think this means we will be responsible for generating a new settings file if we set up a new multi-site, but I think that's a fair trade-off. This really just stops this function from throwing an error for me that the file does not exist.Maybe in a perfect world, this could optionally read the
drupal-scaffold
setting, if it exists, from composer.json, and then use that value, but that felt a little too optimistic to me. Figured I'd see where this one goes first.in
composer.json