Common - Fixed getVersion function #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures return value of string is preserved.
|
ref #7173 |
PabstMirror
approved these changes
Jan 18, 2020
PabstMirror
changed the title
Panisher
pushed a commit
to Panisher/ACE3
that referenced
this pull request
Jan 22, 2020
Ensures return value of string is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ace_common_fnc_getVersioncurrently returns "" due to usinggetText()on a number config entry. I'm unsure if usingversionStrprovides intended behavior sinceversionis a shorter version ofversionStr, this however provides a result which seems to be in line with the docstring above.When merged this pull request will:
versiontoversionStrbased on the return type specified in docs, its likely thatversionused to containversionStr's information. If need be the alternative:str getNumber ()would also work.