Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVersion returns blank string as result #7478

Closed
M3ales opened this issue Jan 18, 2020 · 1 comment · Fixed by #7479
Closed

getVersion returns blank string as result #7478

M3ales opened this issue Jan 18, 2020 · 1 comment · Fixed by #7479
Labels
Milestone

Comments

@M3ales
Copy link
Contributor

M3ales commented Jan 18, 2020

Mods:

  • Arma 3: 1.96.146114 stable
  • CBA: 3.13.0.191116 stable
  • ACE3: 3.13.0.45 stable

Description:
I'm attempting to support both pre-medical rewrite and medical rewrite versions of ace, I figured I could do this by checking version on preInit, and setting a flag of which methods to call in ace's medical API. Sadly it seems ace_common_fnc_getVersion only returns an empty string.

Steps to reproduce:

  • Load any map
  • Open Debug Console
  • Check output of [] call ace_common_fnc_getVersion
  • See that it returns a blank string

Expected behavior:

  • [] call ace_common_fnc_getVersion should return version number

Where did the issue occur?

  • Editor (Singleplayer) & Editor (Multiplayer) & Virtual Arsenal

Log Files:

  • Can upload if need be, didn't see anything out of the ordinary

Additional Context:

  • Worth noting that the version number does still appear in RPT, so I'll look around for where that's printed from, but I still think getVersion should return the version itself rather than having to look elsewhere for it.

  • Checking the version print here which is working with the one in getVersion it seems that it could either be ACE_main being used instead of ace_main as the root, or version not being populated while versionStr is.

Screenshots:
image

@M3ales
Copy link
Contributor Author

M3ales commented Jan 18, 2020

image
Based on config layout, no string version var exists? likely meant to have been changed to versionStr at some point.

Seems like version is there, but wouldn't it be better to return versionStr since it includes more information, and the result is a string in anycase?

M3ales added a commit to M3ales/ACE3 that referenced this issue Jan 18, 2020
Ensures return value of string is preserved.
@PabstMirror PabstMirror added this to the 3.13.1 milestone Jan 18, 2020
PabstMirror pushed a commit that referenced this issue Jan 18, 2020
Ensures return value of string is preserved.
Panisher pushed a commit to Panisher/ACE3 that referenced this issue Jan 22, 2020
Ensures return value of string is preserved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants