Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Finish splint/fracture #7045

Merged
merged 4 commits into from
Jun 22, 2019
Merged

Medical - Finish splint/fracture #7045

merged 4 commits into from
Jun 22, 2019

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Jun 8, 2019

#6940

  • Add replacement items
  • Add p3dmodel
  • Add bone sound effect
  • Add treatment icon

- Add replacement items
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jun 8, 2019
@PabstMirror PabstMirror added this to the Medical Rewrite milestone Jun 8, 2019
@alganthe alganthe mentioned this pull request Jun 8, 2019
28 tasks
@dedmen
Copy link
Contributor

dedmen commented Jun 11, 2019

Add bone sound effect
Add treatment icon

BI has announced that DayZ Mod assets will soon:tm: be released as licensed data pack under ADPL license. But it will probably take too long till they actually release it.
They have break sound and icon.

@bux
Copy link
Member

bux commented Jun 11, 2019

But it will probably take too long till they actually release it.

https://twitter.com/tom_48_97/status/1137018936309014533

are now available

@dedmen
Copy link
Contributor

dedmen commented Jun 11, 2019

are now available

is a lie. The licenses are available, the data packages aren't.

All Licensed Data Packages previously released under APL will also be made available under DPL.

I've asked tom for ETA.

@BaerMitUmlaut
Copy link
Member

Added the splint models from @ElTyranos - thanks again!

@BaerMitUmlaut
Copy link
Member

And sound effects added, too (recorded by me, they're not perfect but will do for now).

@PabstMirror PabstMirror marked this pull request as ready for review June 22, 2019 18:27
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good, haven't tested in-game yet though 👍

[QEGVAR(medical,fracture), {
params ["_unit"];

if (_unit == ACE_player) then {
Copy link
Member

@kymckay kymckay Jun 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it so that nearby players can also hear a fracture (positional sound)?

Additionally, this means unconscious players will hear a fracture. We may want to make that not the case. Sound muted in unconscious.

@alganthe
Copy link
Contributor

alganthe commented Jun 22, 2019

Icons and models look nice, can't test audio because AI destroys me.

EDIT:
Sounds work too, they're a bit crude but it can do for now.

@PabstMirror
Copy link
Contributor Author

maybe look into making sound global later

@PabstMirror PabstMirror merged commit f04b26b into master Jun 22, 2019
@PabstMirror PabstMirror deleted the finishSplint branch June 22, 2019 21:47
@ElTyranos
Copy link
Contributor

Icons and models look nice, can't test audio because AI destroys me.

EDIT:
Sounds work too, they're a bit crude but it can do for now.

Could you please post an in-game picture ? I have not tested it outside bulldozer so it might need a few tweaks.
TY

@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants