Medical AI - Adjust healing logic for rewrite #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PabstMirror
commented
Mar 30, 2019
PabstMirror
commented
- move state machine from config to sqf
- move all healing logic to seperate func
- attempt to handle healing for new system
- move state machine from config to sqf - move all healing logic to seperate func - attempt to handle healing for new system
|
So I gave this a very quick code review and can't see anything incorrect. If I remember right from the meeting these changes have been playtested somewhat too. Needs to be updated for the fracture stuff, but that doesn't seem too hard. Only thing that could perhaps be improved is the way wounds are being chosen to bandage (currently just first open is used) - this might be easier once we optimise wound storage down the line though. I reckon if fracture handling is added we should get this merged and tweak from there. |
Conflicts: addons/medical_ai/stringtable.xml
mharis001
reviewed
Jun 22, 2019
kymckay
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.