Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer old client settings to CBA #5882

Merged
merged 2 commits into from
Dec 10, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/common/XEH_PREP.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ TRACE_1("",QUOTE(ADDON));
PREP(cbaSettings);
PREP(cbaSettings_loadFromConfig);
PREP(cbaSettings_settingChanged);
PREP(cbaSettings_transferUserSettings);

PREP(actionKeysNamesConverted);
PREP(addCanInteractWithCondition);
Expand Down
4 changes: 2 additions & 2 deletions addons/common/XEH_postInit.sqf
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ private _previousVersion = profileNamespace getVariable ["ACE_VersionNumberStrin

// check previous version number from profile
if (_currentVersion != _previousVersion) then {
// do something

INFO_2("Updating ACE from [%1] to [%2]",_previousVersion,_currentVersion);
[_previousVersion] call FUNC(cbaSettings_transferUserSettings);
profileNamespace setVariable ["ACE_VersionNumberString", _currentVersion];
};

Expand Down
45 changes: 45 additions & 0 deletions addons/common/functions/fnc_cbaSettings_transferUserSettings.sqf
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
* Author: PabstMirror
* Transfers a client's old ace settings to cba
*
* Arguments:
* 0: Old Version <STRING>
*
* Return Value:
* None
*
* Example:
* ["3.11.0"] call ace_common_fnc_cbaSettings_transferUserSettings
*
* Public: No
*/
#include "script_component.hpp"

if (!hasInterface) exitWith {};

params [["_lastVersion", "", [""]]];

if ((parseNumber _lastVersion) >= 3.12) exitWith {};

INFO("-Transfering old ACE_Settings to CBA-");

private _aceSettings = configProperties [configFile >> "ACE_Settings", "isClass _x"];
{
private _settingName = configName _x;
private _isClientSettable = (getNumber (_x >> "isClientSettable")) > 0;
private _profileVar = profileNamespace getVariable _settingName;

if (!isNil "_profileVar") then {
private _currentValue = [_settingName, "client"] call CBA_settings_fnc_get;
if (_isClientSettable && {!(_currentValue isEqualTo _profileVar)}) then {
// CBA_settings_fnc_set will do type checking for the old profile var
private _ret = [_settingName, _profileVar, 0, "client", true] call CBA_settings_fnc_set;
INFO_3("Transfering setting [%1: %2] returned %3", _settingName, _profileVar, _ret);
};

// Cleanup old profileNamespace
// profileNamespace setVariable [_settingName, nil];
};
} forEach _aceSettings;

INFO("-Finished Transfering-");