Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer old client settings to CBA #5882

Merged
merged 2 commits into from
Dec 10, 2017
Merged

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Dec 10, 2017

Transfer old ace setting to the cba setting profile var
Should make the conversion smoother for normal users.

Example output:

[ACE] (common) INFO: -Transfering old ACE_Settings to CBA-
[ACE] (common) INFO: Transfering setting [ace_interact_menu_alwaysUseCursorSelfInteraction: true] returned true
[ACE] (common) INFO: Transfering setting [ace_interact_menu_menuBackground: 2] returned true
``

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Dec 10, 2017
@PabstMirror PabstMirror added this to the 3.12.0 milestone Dec 10, 2017
@PabstMirror
Copy link
Contributor Author

@commy2 - Do you see any problems with this?
As far as I could tell CBA_settings_fnc_set should be smart enough and not let me break things

@commy2
Copy link
Contributor

commy2 commented Dec 10, 2017

Get and set shouldn't let you break anything.
I knew ACE_VersionNumberString would be useful for something one day.

@PabstMirror PabstMirror merged commit be67cf0 into master Dec 10, 2017
@PabstMirror PabstMirror deleted the transferClientSettings branch December 10, 2017 18:13
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Transfer old client settings to CBA

* Remove cleanup code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants