Pass functions by "reference" to bis event handlers #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
added
ignore-changelog
commy2
previously requested changes
Feb 14, 2017
addons/hearing/XEH_postInit.sqf
Outdated
| _player setVariable [QGVAR(firedEH), _firedEH]; | ||
| private _explosionEH = _player addEventHandler ["Explosion", LINKFUNC(explosionNear)]; | ||
| private _explosionEH = _player addEventHandler ["Explosion", {call (explosionNear)}]; |
addons/hearing/XEH_postInit.sqf
Outdated
| @@ -60,9 +60,9 @@ GVAR(lastPlayerVehicle) = objNull; | |||
| }; | |||
| // Don't add a new EH if the unit respawned | |||
| if ((_player getVariable [QGVAR(firedEH), -1]) == -1) then { | |||
| private _firedEH = _player addEventHandler ["FiredNear", LINKFUNC(firedNear)]; | |||
| private _firedEH = _player addEventHandler ["FiredNear", {call (firedNear)}]; | |||
addons/hearing/XEH_postInit.sqf
Outdated
| @@ -35,7 +35,7 @@ GVAR(lastPlayerVehicle) = objNull; | |||
| TRACE_2("removed veh eh",_firedEH,GVAR(lastPlayerVehicle)); | |||
| }; | |||
| if ((!isNull _vehicle) && {_player != _vehicle}) then { | |||
| private _firedEH = _vehicle addEventHandler ["FiredNear", LINKFUNC(firedNear)]; | |||
| private _firedEH = _vehicle addEventHandler ["FiredNear", {call (firedNear)}]; | |||
|
For reference: https://feedback.bistudio.com/T123355 |
commy2
approved these changes
Feb 14, 2017
thojkooi
pushed a commit
that referenced
this pull request
Mar 13, 2017
* Pass functions by "reference" to bis event handlers * Add Doc * Fix Conflicts: addons/laserpointer/XEH_postInit.sqf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a discovery from @dedmen (ref CBATeam/CBA_A3#588)
Passing a large code function to a BIS EH has a significant performance cost.
Using interact_menu as an example.
So an extra processing time of ~0.3 ms when passing the entire function vs passing a short bit of code that calls the function.