Dogtags #3962

nicolasbadano · 2016-06-20T19:06:32Z

When merged this pull request will:

Merge PR Dogtags #3600 to a dogtag branch in our repo
Restyle the dogtags
Add unique service number and blood types to all dogtags

I think this is ready for 3.6.0. Improvements can be pushed for later, given they wouldn't interfere (there's no public API yet).

Proposed by @jonpas :

Change the dog tag items to magazines and use their unique ID as identifier

I'm been thinking about the proposal, and although it's easy to implement. However, I think it's not needed for first release.

…ts support, little cleanup

Added custom dogtag model and images

…edzikPL-dogtags

- Leave up to CBA to decide if events should be local or remote - Imp

commy2 · 2016-06-20T19:10:35Z

addons/dogtags/functions/fnc_getDogtagData.sqf

+	str(floor random 9) + str(floor random 9) + str(floor random 9) + "-" +
+		str(floor random 9) + str(floor random 9) + "-" +
+		str(floor random 9) + str(floor random 9) + str(floor random 9),
+	selectRandom ["O POS", "O NEG", "A POS", "A NEG", "B POS", "B NEG",


commy2 · 2016-06-20T19:11:45Z

Im bringing up a silly idea again I had back in AGM.
Why don't we dynamically create the blood types using the player name or steam ui or something like that.
It would mean that these blood types are consistent from mission to mission.

nicolasbadano · 2016-06-20T19:43:45Z

Incoming

kymckay · 2016-06-20T19:44:21Z

I don't think that's silly, I like it 👍

I'd probably do a parseNumber on the getPlayerUID (ID64) and then wrap around the array of types like so: _arr = [blablabla]; _arr select ((parseNumber (getPlayerUID _target)) % (count _arr))

kymckay · 2016-06-20T19:49:40Z

addons/dogtags/functions/fnc_getDogtagData.sqf

@@ -19,13 +19,24 @@ private _dogTagData = _target getVariable QGVAR(dogtagData);
 if (!isNil "_dogTagData") exitWith {_dogTagData};

 // Create dog tag data once for the unit: nickname, code (eg. 135-13-900) and blood type
+private ["_bloodTypeIndex", "_code"];
+//hint getplayeruid _target;
+if ((typename getplayeruid _target) == "SCALAR") then {


This will never be true, also not using isEqualType 😝

Why wouldn't it work?

I don't get the point of this.

getPlayerUID always returns a string

getPlayerUID is the correct case. As far as I can tell it will always report a string, so it will never be typeOf SCALAR

commy2 · 2016-06-20T19:53:47Z

Incoming

~~I think I was faster, haha~~

NVM I'm stupid

Store object instead of bool to indicate when dogtags have been taken When object respawns, the the old object reference won't apply (defacto reset)

nicolasbadano · 2016-06-20T20:14:51Z

getPlayerUID doen't work for this, because it returns "" for dead players. I'll switch to something inspired on @commy2 's code

kymckay · 2016-06-20T20:16:19Z

addons/dogtags/functions/fnc_getDogtagData.sqf

-    _code = (str getplayeruid _target) select [0, 3] + "-" +
-            (str getplayeruid _target) select [3, 2] + "-" +
-            (str getplayeruid _target) select [5, 3];
+if !(getplayeruid _target in ["", "_SP_AI_", "_SP_PLAYER_"]) then {


Minor, but it would probably make sense to store the value of getPlayerUID in a variable instead of using the command multiple times (also the lack of camel case triggers me 🐫)

Otherwise 👍

Fix issue with dogtag respawn/setVariable

…to dogtags # Conflicts: # addons/dogtags/functions/fnc_getDogtagData.sqf

nicolasbadano · 2016-06-20T20:21:37Z

Actually, I just merged @commy2 's PR. The service number is not persistent anymore, but that can be improved in the future.

kymckay · 2016-06-20T20:28:48Z

Service number could be made persistent using:

_nums = ((toArray _name) select [0,8]) apply { _x % 10 };

while {count _nums < 8} do {
    _nums pushBack (floor random 10);
};

Then just split as necessary. I'm not familiar with the format of service numbers, so not sure if the floor random 9 in the existing code was an oversight or if they only use 0-8.

Only semi-persistent for names shorter than 8 characters long (suppose you could loop around or something if you wanted true persistence for those also).

nicolasbadano · 2016-06-20T20:37:30Z

@SilentSpike, they totally go from 0 to 8

nicolasbadano · 2016-06-20T20:46:17Z

Ok guys, do you think this should be in 3.6.0?

👍 👎

kymckay · 2016-06-20T20:49:45Z

Functional (presumably) version of above snippet:

_nums = ((toArray _name) select [0,8]) apply { _x % 10 };

while {count _nums < 8} do {
    _nums pushBack (floor random 10);
};

_code = ([_nums select [0,3],_nums select [3,2], _nums select [5,3]] apply { _x joinString "" }) joinString "-";

thojkooi · 2016-06-20T22:23:53Z

Blood type? I'm not so sure about that.

nicolasbadano · 2016-06-20T23:05:00Z

Blood type? I'm not so sure about that.

I guess you may argue that we shouldn't give players different blood types if we don't simulate blood compatibility in medical. But you might as well say we do, only that blood bags contain O Negative blood, which is close to universally compatible.

Anyway, I just wanted dogtags to look as genuine as possible, and they usually do feature blood types on them. I could randomize religion instead, but that sounds even more controversial.

jonpas · 2016-06-20T23:32:21Z

I like blood type, religion is kinda meh unless we put "Jedi" on all of them (I'd argue that's a good idea actually!).

nicolasbadano · 2016-06-21T00:04:57Z

OC I was joking about religion, mostly because I don't want to have to deal with tickets complaining about Al'Qaedan Jews and Chinese Quakers. And oc Klingon Jedis would create complains too.

654wak654 · 2016-06-21T00:11:14Z

About getPlayerUID returning an empty string on dead bodies, couldn't you go around that by generating the blood type before a player dies? It only has to be done once ever anyway. Could even put it in a profile var and let people play around with it.

And for anything else could always fallback to _name.

kripto202 · 2016-06-21T00:27:41Z

is it possible where you can look up the dog tags when they are in body bags?

jonpas · 2016-06-21T00:29:00Z

I support @kripto202 's idea, should be straightfoward implementation with ace_placedInBodyBag.

kymckay · 2016-06-21T16:07:54Z

couldn't you go around that by generating the blood type before a player dies?

This is true, we could use an XEH PostInit or something, however the way it's done now means that code doesn't run unless it needs to. You could go a whole mission without anybody checking dogtags.

Similar to how we're handling blood types, uses the unit's name to generate a valid three/two/four format SSN. For names less than 9 characters long this will currently generate a unique SSN only up to the length of the name and append valid digits as necessary.

Names shorter than the required 9 characters are now reused until we have 9 characters - making for fully unique generation. To keep things distributed as pleasantly as possible they're itterated over with a step of two - alternating between odd and even indexes every full loop. Similarly, the slice of string used for names longer than 9 characters is now offset based on the length of the name.

Generate SSN of unit from their name

Add dogtag actions to body bags

SzwedzikPL and others added 13 commits March 19, 2016 16:17

Initial commit dogtags

ca3171a

double dogtag support, fix addDogtagItem event in mp, unconscious uni…

1cdecf7

…ts support, little cleanup

move dogtag macros to CfgWeapons

174e69c

Added custom dogtag model and images

9d4bd0f

Adjusted single and double dogtag renders

5dbe99b

Merge pull request #1 from BaerMitUmlaut/dogtags

8bcf24a

Added custom dogtag model and images

Merge branch 'acemod/master' into dogtags

aa407a4

dogtag picture

5313672

Merge branch 'acemod/master' into dogtags

acdfa52

CBA events

0e247bd

Merge branch 'dogtags' of https://github.com/SzwedzikPL/ACE3 into Szw…

1f74bfc

…edzikPL-dogtags

Restyle the dog tag text.

e58d829

- Add random service number and bloodtypes to all units.

0d30bf1

- Leave up to CBA to decide if events should be local or remote - Imp

nicolasbadano added the kind/feature Release Notes: **ADDED:** label Jun 20, 2016

commy2 reviewed Jun 20, 2016
View reviewed changes

I can't believe it happened to me.

6df82aa

Attempt on making blood type and service number unique for players

88cf6aa

kymckay reviewed Jun 20, 2016
View reviewed changes

add function to report a blood type which is fixed to the units name

c883132

nicolasbadano and others added 2 commits June 20, 2016 17:04

Parse the first portion of the uid

c47898a

Fix issue with dogtag respawn/setVariable

578477e

Store object instead of bool to indicate when dogtags have been taken When object respawns, the the old object reference won't apply (defacto reset)

kymckay reviewed Jun 20, 2016
View reviewed changes

nicolasbadano added 2 commits June 20, 2016 17:17

Merge pull request #3965 from acemod/fixDogtagRespawn

09fd2c4

Fix issue with dogtag respawn/setVariable

Merge branch 'dogtags_blood_type' of github.com:KoffeinFlummi/ACE3 in…

171e6b2

…to dogtags # Conflicts: # addons/dogtags/functions/fnc_getDogtagData.sqf

nicolasbadano added 2 commits June 20, 2016 17:37

Nah, they don't

7e3e101

Tidy up text position to properly acommodate two line names

7f39748

Add dogtag actions to body bags

3972504

PabstMirror mentioned this pull request Jun 21, 2016

Add dogtag actions to body bags #3969

Merged

kymckay added 2 commits June 21, 2016 18:42

kymckay mentioned this pull request Jun 21, 2016

Generate SSN of unit from their name #3971

Merged

nicolasbadano added 2 commits June 21, 2016 20:46

Merge pull request #3971 from acemod/dogtags-player-ssn

3fa1758

Generate SSN of unit from their name

Merge pull request #3969 from acemod/dogtag-bodybag

6801954

Add dogtag actions to body bags

nicolasbadano added this to the 3.6.0 milestone Jun 23, 2016

commy2 modified the milestones: 3.7.0, 3.6.0 Jun 27, 2016

thojkooi merged commit cd08e00 into master Jun 29, 2016

thojkooi deleted the dogtags branch June 29, 2016 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dogtags #3962

Dogtags #3962

nicolasbadano commented Jun 20, 2016 •

edited

Loading

commy2 Jun 20, 2016

commy2 commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016

kymckay Jun 20, 2016

nicolasbadano Jun 20, 2016

commy2 Jun 20, 2016

kymckay Jun 20, 2016 •

edited

Loading

commy2 Jun 20, 2016

commy2 commented Jun 20, 2016 •

edited

Loading

nicolasbadano commented Jun 20, 2016

kymckay Jun 20, 2016

kymckay Jun 20, 2016

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016 •

edited

Loading

nicolasbadano commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016

thojkooi commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

jonpas commented Jun 20, 2016 •

edited

Loading

nicolasbadano commented Jun 21, 2016

654wak654 commented Jun 21, 2016 •

edited

Loading

kripto202 commented Jun 21, 2016

jonpas commented Jun 21, 2016

kymckay commented Jun 21, 2016

Dogtags #3962

Dogtags #3962

Conversation

nicolasbadano commented Jun 20, 2016 • edited Loading

commy2 Jun 20, 2016

Choose a reason for hiding this comment

commy2 commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016

kymckay Jun 20, 2016

Choose a reason for hiding this comment

nicolasbadano Jun 20, 2016

Choose a reason for hiding this comment

commy2 Jun 20, 2016

Choose a reason for hiding this comment

kymckay Jun 20, 2016 • edited Loading

Choose a reason for hiding this comment

commy2 Jun 20, 2016

Choose a reason for hiding this comment

commy2 commented Jun 20, 2016 • edited Loading

nicolasbadano commented Jun 20, 2016

kymckay Jun 20, 2016

Choose a reason for hiding this comment

kymckay Jun 20, 2016

Choose a reason for hiding this comment

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016 • edited Loading

nicolasbadano commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

kymckay commented Jun 20, 2016

thojkooi commented Jun 20, 2016

nicolasbadano commented Jun 20, 2016

jonpas commented Jun 20, 2016 • edited Loading

nicolasbadano commented Jun 21, 2016

654wak654 commented Jun 21, 2016 • edited Loading

kripto202 commented Jun 21, 2016

jonpas commented Jun 21, 2016

kymckay commented Jun 21, 2016

nicolasbadano commented Jun 20, 2016 •

edited

Loading

kymckay Jun 20, 2016 •

edited

Loading

commy2 commented Jun 20, 2016 •

edited

Loading

kymckay commented Jun 20, 2016 •

edited

Loading

jonpas commented Jun 20, 2016 •

edited

Loading

654wak654 commented Jun 21, 2016 •

edited

Loading