Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogtags #3600

Closed
wants to merge 10 commits into from
Closed

Dogtags #3600

wants to merge 10 commits into from

Conversation

SzwedzikPL
Copy link
Contributor

@SzwedzikPL SzwedzikPL commented Mar 19, 2016

When merged this pull request will:

  • Add option to check / take dogtag from dead unit
  • Every dogtag item is unique, nickname assigned to item is saved on server

Demo: https://www.youtube.com/watch?v=qMeOXQ0UYFE

Todo

  • Item icon
  • Item model
  • CBA Events
  • Action: check all dogtags at once
  • Change dogtags into magazines?
  • Proper dedicated multiplayer tests

@nicolasbadano nicolasbadano added this to the 3.6.0 milestone Mar 19, 2016
@nicolasbadano nicolasbadano added the kind/feature Release Notes: **ADDED:** label Mar 19, 2016
@nicolasbadano
Copy link
Contributor

This was yet another item in my TODO list; I'm glad to see someone make progress!!

Implementation looks very good! One thing that I'd like to see implemented eventually is this: afaik, the chain contains a set of two dogtags. One is removed from casualties, but the other one is left with the remains, in order to be able to identify them later. So in a "fresh" casualty, both dogtags should be displayed, and once the first one was removed, the remaining one should be displayed, but without the possibility of taking it.

@SzwedzikPL
Copy link
Contributor Author

Implementation looks very good! One thing that I'd like to see implemented eventually is this: afaik, the chain contains a set of two dogtags. One is removed from casualties, but the other one is left with the remains, in order to be able to identify them later. So in a "fresh" casualty, both dogtags should be displayed, and once the first one was removed, the remaining one should be displayed, but without the possibility of taking it.

Nice idea. It would be great if someone could prepare brackgrounds for both versions of display (i mean background with both dogtags and background with only one). This UI is very old. I used it in my community version of dogtag module. I think it needs some love :)

private _id = getNumber (configFile >> "CfgWeapons" >> _x >> QGVAR(tagID));
if(_id > 0) then {
_unitDogtags pushback _x;
_unitDogtagIDs pushback _id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushBack

@SzwedzikPL
Copy link
Contributor Author

new demo: https://www.youtube.com/watch?v=2V2tPYBqFak
@esteldunedain Is this what you had in mind?

@nicolasbadano
Copy link
Contributor

@esteldunedain Is this what you had in mind?

Yeah, pretty much! Thank you.

@BaerMitUmlaut
Copy link
Member

Is that image taken from Battlefield? If so I can make a custom one to avoid copyright issues.

@SzwedzikPL
Copy link
Contributor Author

Is that image taken from Battlefield? If so I can make a custom one to avoid copyright issues.

I'm not sure but it's possible. Someone gave me this about year ago. I really don't remember. If you can make your own i will be grateful :)

@Orakel78
Copy link

Will there be other dogtag models ?

Quite a few armies / countries uses dog tags which you break of one piece and leave the other half behind.

@nicolasbadano
Copy link
Contributor

Will there be other dogtag models ?

Maybe in the future. Let's get guy finish a first version first ;)

@gienkov
Copy link
Contributor

gienkov commented Mar 20, 2016

That dogtag is from ACE2 I bet.

@SzwedzikPL
Copy link
Contributor Author

That dogtag is from ACE2 I bet.

Nope

@BryanBoru
Copy link

The more I look at this the more I am certain that dogtag image is taken from battlefield. I am trying to find a decent model for ya and just haven't had luck with one that would accept the text addition well.

@BaerMitUmlaut
Copy link
Member

I'm currently making a model and texture.

@Khaosmatic
Copy link

Khaosmatic commented May 19, 2016

Is it be possible to give the individual dog tag items their own name? This would then alleviate the need of having to look at for example 'Dog Tag #1' to find out which one is which.

@jonpas
Copy link
Member

jonpas commented Jun 9, 2016

This has the same issue as #3601 with IDs #3601 (comment)

@commy2
Copy link
Contributor

commy2 commented Jun 11, 2016

  • CBA events

@jonpas
Copy link
Member

jonpas commented Jun 19, 2016

Moving to next milestone as this is still WIP and ideas are floating around on how to handle this the best way.

@jonpas jonpas modified the milestones: 3.7.0, 3.6.0 Jun 19, 2016
@nicolasbadano nicolasbadano mentioned this pull request Jun 20, 2016
1 task
@SzwedzikPL SzwedzikPL closed this Jun 20, 2016
@SzwedzikPL SzwedzikPL deleted the dogtags branch June 21, 2016 10:52
@thojkooi thojkooi modified the milestone: 3.7.0 Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:** status/WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants