NOISSUE: Add Publish/Subscribe to channels #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
force-pushed
the
add_organization_things_channels_auth
branch
from
8f73300
to
b47d3f6
Compare
dborovcanin
force-pushed
the
auth-refactor
branch
from
41328b1
to
f6d85df
Compare
arvindh123
force-pushed
the
add_organization_things_channels_auth
branch
from
ed68d71
to
f6862fe
Compare
arvindh123
force-pushed
the
auth-refactor
branch
from
f6d85df
to
643db8c
Compare
dborovcanin
force-pushed
the
auth-refactor
branch
from
643db8c
to
7382dbd
Compare
arvindh123
force-pushed
the
auth-refactor
branch
from
7382dbd
to
2e43ba9
Compare
arvindh123
force-pushed
the
add_organization_things_channels_auth
branch
from
ac4e5fd
to
18d21ba
Compare
dborovcanin
requested changes
Nov 4, 2024
pkg/connections/type.go
Outdated
Comment on lines
56
to
62
| func NewType(c uint) (Type, error) { | ||
| if err := Type(c).CheckType(); err != nil { | ||
| return Invalid, err | ||
| } | ||
| return Type(c), nil | ||
|
|
||
| } |
pkg/connections/type.go
Outdated
Comment on lines
35
to
44
| func (c Type) CheckType() error { | ||
| switch c { | ||
| case Publish: | ||
| return nil | ||
| case Subscribe: | ||
| return nil | ||
| default: | ||
| return fmt.Errorf("Unknown connection type %d", c) | ||
| } | ||
| } |
There was a problem hiding this comment.
let's not attach this to Type, but make this an exported function CheckType(t Type) error.
pkg/connections/type.go
Outdated
|
|
||
| var errInvalidConnType = errors.New("invalid connection type") | ||
|
|
||
| type Type uint8 |
arvindh123
force-pushed
the
auth-refactor
branch
from
2e43ba9
to
b6e8587
Compare
arvindh123
force-pushed
the
add_organization_things_channels_auth
branch
2 times, most recently
from
2009c3c
to
9e2d276
Compare
- add: publish subscribe Signed-off-by: Arvindh <[email protected]> add publish subscribe Signed-off-by: Arvindh <[email protected]> add publish subscribe Signed-off-by: Arvindh <[email protected]> fix: sdk import paths Signed-off-by: Arvindh <[email protected]> fix: domain authz Signed-off-by: Arvindh <[email protected]> fix: users test Signed-off-by: Arvindh <[email protected]> fix: coap authz Signed-off-by: Arvindh <[email protected]> rename: connections.Type to connections.ConnType Signed-off-by: Arvindh <[email protected]>
arvindh123
force-pushed
the
add_organization_things_channels_auth
branch
from
9e2d276
to
2378aed
Compare
dborovcanin
requested changes
Nov 5, 2024
cmd/domains/main.go
Outdated
Comment on lines
238
to
239
| counter, latency := prometheus.MakeMetrics("domains", "api") | ||
| svc = dmw.MetricsMiddleware(svc, counter, latency) |
There was a problem hiding this comment.
Add latency after auth also, we since auth middleware will affect latency.
| return fmt.Errorf("Unknown connection type %d", c) | ||
| } | ||
| } | ||
| func (c ConnType) String() string { |
There was a problem hiding this comment.
Add an empty line between funcs.
| } | ||
| return ConnType(c), nil | ||
|
|
||
| } |
pkg/connections/type.go
Outdated
| return ConnType(c), nil | ||
|
|
||
| } | ||
| func StringToConnType(c string) (ConnType, error) { |
There was a problem hiding this comment.
Rename to ParseConnType (string -> other type = parsing and other type -> string = string/format).
Signed-off-by: Arvindh <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/magistrala
that referenced
this pull request
Nov 10, 2024
Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/magistrala
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/magistrala
that referenced
this pull request
Nov 12, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
added a commit
to arvindh123/magistrala
that referenced
this pull request
Nov 18, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes