MG-2456 - Refactor auth #2409

arvindh123 · 2024-09-03T13:47:20Z

What type of PR is this?

This is a feature because it adds the following functionality mentioned in following tickets

What does this do?

It adds the features mentioned in this ticket #2456

Which issue(s) does this PR fix/relate to?

Related Issue Refactor Authorization #2456
Resolves partially Refactor Authorization #2456
Resolves partially Feature: Use Postgres LTREE for groups hierarchy #2214
Resolves partially Feature: Enhance OpenAPI Specification by Structuring Endpoints Based on Entities for Improved Clarity and User Experience #2053

Have you included tests for your changes?

Yes , Tested manually

Did you document any new/modified feature?

No

Notes

Signed-off-by: Arvindh <[email protected]>

dborovcanin · 2024-10-08T07:55:49Z

@arvindh123 Please update the description and link all the relevant issues.

Signed-off-by: Arvindh <[email protected]>

dborovcanin · 2024-10-24T14:19:42Z

things/api/grpc/server.go

 	"github.com/absmach/magistrala/pkg/apiutil"
 	"github.com/absmach/magistrala/pkg/errors"
 	svcerr "github.com/absmach/magistrala/pkg/errors/service"
-	"github.com/absmach/magistrala/things"
+	pThings "github.com/absmach/magistrala/things/private"


Rename to things.

dborovcanin · 2024-10-24T14:23:00Z

things/private/service.go

+	"github.com/absmach/magistrala/things"
+)
+
+type Service interface {


Add a doc comment that service is just a wrapper around Repository. Also add a doc.go that explains the purpose of private package and Service.

dborovcanin · 2024-10-24T14:24:56Z

things/service.go

@@ -8,59 +8,46 @@ import (

 	"github.com/absmach/magistrala"


Add an alias mg. It's shorter and unambiguous.

Signed-off-by: Arvindh <[email protected]>

dborovcanin

This is still WIP, but we are merging to simplify review process.

Signed-off-by: Arvindh <[email protected]>

Signed-off-by: Arvindh <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]>

Signed-off-by: Arvindh <[email protected]>

Signed-off-by: Arvindh <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]> Signed-off-by: nyagamunene <[email protected]>

- Set/Unset parent Group for Things and Channels (#2486) - Move groups out of pkg (#2493) - Separate Things authn and Channels authz (#2496) Signed-off-by: Arvindh <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]>

- Set/Unset parent Group for Things and Channels (#2486) - Move groups out of pkg (#2493) - Separate Things authn and Channels authz (#2496) Signed-off-by: Arvindh <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> Signed-off-by: nyagamunene <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]>

- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>

arvindh123 requested a review from dborovcanin September 3, 2024 13:47

dborovcanin changed the title ~~NOISSUE: Add Role to entities.~~ NOISSUE: Add Role to entities Sep 24, 2024

dborovcanin changed the title ~~NOISSUE: Add Role to entities~~ NOISSUE - Add Role to entities Sep 24, 2024

arvindh123 added 16 commits September 26, 2024 18:13

spicedb schema

697532f

Signed-off-by: Arvindh <[email protected]>

add schema v4

d1c5519

Signed-off-by: Arvindh <[email protected]>

add roles

3f8881d

Signed-off-by: Arvindh <[email protected]>

move domains out of auth service

e73ac7b

Signed-off-by: Arvindh <[email protected]>

add domains to auth main.go

a4d8774

Signed-off-by: Arvindh <[email protected]>

domain inheritance roles

f86ee1a

Signed-off-by: Arvindh <[email protected]>

domain inheritance roles fix

b2220d2

Signed-off-by: Arvindh <[email protected]>

fix roles

84f6f1a

Signed-off-by: Arvindh <[email protected]>

fix roles

dcd1699

Signed-off-by: Arvindh <[email protected]>

fix domains

a8d4728

Signed-off-by: Arvindh <[email protected]>

rename operations to capabilities

3b4981a

Signed-off-by: Arvindh <[email protected]>

change logic for permission

dc85a8e

Signed-off-by: Arvindh <[email protected]>

rollback to actions

0490809

Signed-off-by: Arvindh <[email protected]>

add groups, thing

652f4ec

Signed-off-by: Arvindh <[email protected]>

add groups to users

8eaf7d1

Signed-off-by: Arvindh <[email protected]>

add roles table name prefix

4a1dffa

Signed-off-by: Arvindh <[email protected]>

arvindh123 force-pushed the add_organization branch from 292fcd4 to 4a1dffa Compare September 26, 2024 12:49

arvindh123 added 5 commits September 26, 2024 20:54

update with new auth client and added temp patch

73f12b5

Signed-off-by: Arvindh <[email protected]>

fix roles table prefix

8948b79

Signed-off-by: Arvindh <[email protected]>

add groups with ltree

c3df9ff

Signed-off-by: Arvindh <[email protected]>

add channels

7b59021

Signed-off-by: Arvindh <[email protected]>

add channels

fa0e064

Signed-off-by: Arvindh <[email protected]>

dborovcanin changed the title ~~NOISSUE - Add Role to entities~~ MG-2456 - Refactor auth Oct 8, 2024

This was referenced Oct 8, 2024

MG-2214 - Add LTREE Path to Groups #2223

Closed

Feature: Use Postgres LTREE for groups hierarchy #2214

Closed

dborovcanin mentioned this pull request Oct 17, 2024

Feature: Enhance OpenAPI Specification by Structuring Endpoints Based on Entities for Improved Clarity and User Experience #2053

Open

arvindh123 added 7 commits October 24, 2024 08:52

Merge branch 'main' into add_organization

5ace4eb

Fix: users endpoin test

332d73d

Signed-off-by: Arvindh <[email protected]>

add external operation and set parent for channels

53a0482

Signed-off-by: Arvindh <[email protected]>

remove parent relation on group delete

7261903

Signed-off-by: Arvindh <[email protected]>

remove parent relation on group delete

a6a7994

Signed-off-by: Arvindh <[email protected]>

seperate things gRPC function to private

0b6c2d9

Signed-off-by: Arvindh <[email protected]>

seperate things gRPC function to private

cc9001e

Signed-off-by: Arvindh <[email protected]>

dborovcanin requested changes Oct 24, 2024

View reviewed changes

address comments

77ed65d

Signed-off-by: Arvindh <[email protected]>

dborovcanin approved these changes Oct 24, 2024

View reviewed changes

dborovcanin merged commit 15df251 into absmach:auth-refactor Oct 24, 2024
1 of 2 checks passed

dborovcanin deleted the add_organization branch October 24, 2024 14:41

dborovcanin restored the add_organization branch October 24, 2024 14:41

dborovcanin pushed a commit that referenced this pull request Oct 25, 2024

MG-2456 - Refactor auth (#2409)

8d8db9b

Signed-off-by: Arvindh <[email protected]>

dborovcanin pushed a commit that referenced this pull request Oct 28, 2024

MG-2456 - Refactor auth (#2409)

16f0118

Signed-off-by: Arvindh <[email protected]>

dborovcanin pushed a commit that referenced this pull request Oct 28, 2024

MG-2456 - Refactor auth (#2409)

d89d015

Signed-off-by: Arvindh <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]>

nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 28, 2024

MG-2456 - Refactor auth (absmach#2409)

9325405

Signed-off-by: Arvindh <[email protected]>

nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 29, 2024

MG-2456 - Refactor auth (absmach#2409)

9458bae

Signed-off-by: Arvindh <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]> Signed-off-by: nyagamunene <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MG-2456 - Refactor auth #2409

MG-2456 - Refactor auth #2409

arvindh123 commented Sep 3, 2024 •

edited by dborovcanin

Loading

dborovcanin commented Oct 8, 2024

dborovcanin Oct 24, 2024

dborovcanin Oct 24, 2024

dborovcanin Oct 24, 2024

dborovcanin left a comment

MG-2456 - Refactor auth #2409

MG-2456 - Refactor auth #2409

Conversation

arvindh123 commented Sep 3, 2024 • edited by dborovcanin Loading

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

dborovcanin commented Oct 8, 2024

dborovcanin Oct 24, 2024

Choose a reason for hiding this comment

dborovcanin Oct 24, 2024

Choose a reason for hiding this comment

dborovcanin Oct 24, 2024

Choose a reason for hiding this comment

dborovcanin left a comment

Choose a reason for hiding this comment

arvindh123 commented Sep 3, 2024 •

edited by dborovcanin

Loading