Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABP CLI - Throw exceptions instead swallowing #18519

Merged
merged 1 commit into from
Dec 19, 2023
Merged

ABP CLI - Throw exceptions instead swallowing #18519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/CliService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
catch (Exception ex)
{
Logger.LogException(ex);
throw;

Check warning on line 87 in framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/CliService.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/CliService.cs#L87 

Added line #L87 was not covered by tests
}
}

Expand Down
1 change: 1 addition & 0 deletions framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BundleCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
catch (BundlingException ex)
{
Logger.LogError(ex.Message);
throw;

Check warning on line 52 in framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BundleCommand.cs

View check run for this annotation

Codecov / codecov/patch

framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BundleCommand.cs#L52 

Added line #L52 was not covered by tests
}
}

Expand Down
Loading