ABP CLI - Throw exceptions instead swallowing #18519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ABP CLI exit code is always 0 even if there is an error. When it's used in pipeline (
abp install-libs
), or it's called by another program (abpdev in my case), errors can't be recognized.So, I threw the exception instead of swallowing it. And now, when a command fails in ABP CLI, it can be handled programmatically.
Checklist
How to test it?
Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.