Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package purl model updates #1368

Merged
merged 29 commits into from
Dec 29, 2023
Merged

Package purl model updates #1368

merged 29 commits into from
Dec 29, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Dec 19, 2023

This PR does two major changes:

  1. internally we now store Package URL qualifiers as a string and not a JSON field anymore. The API is unchanged for now but will change in the future and will also return a string and not a dict/object.

  2. Because of qualifiers storage inconsistencies, we had several data issues that the schema changes addresses. We also have namespaces inconsistencies issues described in Remove redundant package-urls from VCIO #1327 and we use a sequence of data and schema migrations to fix these issues and normalize the storage of name and namespaces for all records now and in the future.

Therefore, this PR fixes:

pombredanne and others added 27 commits December 26, 2023 20:59
Create qualifiers_temp temp field

Reference: #1327
Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp

Reference: #1327
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Create qualifiers_temp temp field

Reference: #1327
Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp

Reference: #1327
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>


class Package(PackageURLMixin):
"""
A software package with related vulnerabilities.
"""

"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments may no longer be needed now.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Just a minor nit wrt. dangling comments that you may want to remove.

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 merged commit 5932722 into main Dec 29, 2023
11 checks passed
@TG1999 TG1999 deleted the package-purl-model-updates branch December 29, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants