-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant package-urls from VCIO #1327
Comments
@TG1999 Re the 2d scenario, I don't recall any discussion of how we'll decide which of the duplicates to remove. The difference is not limited to the structure of the |
As per my discussion with @pombredanne
|
Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Create qualifiers_temp temp field Reference: aboutcode-org#1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: aboutcode-org#1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Create qualifiers_temp temp field Reference: aboutcode-org#1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Copy qualifiers to qualifiers_temp Reference: aboutcode-org#1327 Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: aboutcode-org#1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: aboutcode-org#1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: aboutcode-org#1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: aboutcode-org#1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: aboutcode-org#1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
* Add missing migration for vulnerability.status Signed-off-by: Philippe Ombredanne <[email protected]> * Migrate qualifiers to plain charfield step 1 Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]> * Migrate qualifiers to plain charfield step 2 Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]> * Add qualifiers_temp in unique_together step 3 Signed-off-by: Tushar Goel <[email protected]> * Remove qualifiers from qunique_together step 4 Signed-off-by: Tushar Goel <[email protected]> * Copy qualifiers_temp to qualifiers step 5 Signed-off-by: Tushar Goel <[email protected]> * Add qualifiers in unique_together step 6 Signed-off-by: Tushar Goel <[email protected]> * Delete qualifiers_temp and remove it from unique_togther step 7 Signed-off-by: Tushar Goel <[email protected]> * Formatting changes Signed-off-by: Tushar Goel <[email protected]> * Correct the 0045 migration Signed-off-by: Tushar Goel <[email protected]> * Migrate qualifiers to plain charfield step 1 Create qualifiers_temp temp field Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]> * Migrate qualifiers to plain charfield step 2 Copy qualifiers to qualifiers_temp Reference: #1327 Signed-off-by: Philippe Ombredanne <[email protected]> * Add qualifiers_temp in unique_together step 3 Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]> * Remove qualifiers from unique_together step 4 Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]> * Copy qualifiers_temp to qualifiers step 5 Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]> * Add qualifiers in unique_together step 6 Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]> * Delete qualifiers_temp field and unique_togther step 7 Reference: #1327 Signed-off-by: Tushar Goel <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]> * Format models.py Signed-off-by: Tushar Goel <[email protected]> * Remove dupe Packages from qualifiers Signed-off-by: Philippe Ombredanne <[email protected]> * Remove dupe Packages from ns/name Signed-off-by: Philippe Ombredanne <[email protected]> * Correct migrations and add tests Signed-off-by: Tushar Goel <[email protected]> * Fix tests Signed-off-by: Tushar Goel <[email protected]> * Update tests Signed-off-by: Tushar Goel <[email protected]> * Fix tests Signed-off-by: Tushar Goel <[email protected]> * Remove tests for warts Signed-off-by: Tushar Goel <[email protected]> * Add changelog Signed-off-by: Tushar Goel <[email protected]> * Update PR according to recent changes Signed-off-by: Tushar Goel <[email protected]> * Update tests Signed-off-by: Tushar Goel <[email protected]> * Address review comments Signed-off-by: Tushar Goel <[email protected]> --------- Signed-off-by: Philippe Ombredanne <[email protected]> Signed-off-by: Tushar Goel <[email protected]> Co-authored-by: Philippe Ombredanne <[email protected]>
Currently, we store duplicated package-urls because of the way they are different structurally but similar when constructed as a purl whole, for example:
1st Scenario:
Purl A-
type-"pypi", namespace- "", name - "foo/bar"
Purl B-
type-"pypi", namespace-"foo", name - "bar"
They are structurally different, but their purl will be identical i.e "pkg:pypi/foo/bar"
2nd Scenario:
https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-tuesday-2023-10-24-at-1600-utc discussed here in the weekly meeting
The solution for 2nd scenario was discussed in the weekly meeting, but what should be done for 1st scenario ?
The text was updated successfully, but these errors were encountered: