Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ClientOptions in Eris constructor #1255

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Require ClientOptions in Eris constructor #1255

merged 1 commit into from
Aug 4, 2021

Conversation

Ashesh3
Copy link
Contributor

@Ashesh3 Ashesh3 commented Aug 4, 2021 •
edited
Loading

Class Client constructor makes ClientOptions a required parameter, since intents is no longer optional.

Eris client options (only intents is required)

However, the top level Eris function allows the user to mistakenly bypass this requirement of specifying ClientOptions with the intent property while calling the Client constructor.

This change should make it as so ClientOptions is required while calling Eris just as intended.

@DonovanDMC
Copy link
Contributor

mm Eric

@Ashesh3 Ashesh3 changed the title Require ClientOptions in Eric constructor Require ClientOptions in Eris constructor Aug 4, 2021
@Ashesh3
Copy link
Contributor Author

Ashesh3 commented Aug 4, 2021

mm Eric

2am no coffee side effects, fixed

@bsian03 bsian03 added the typings label Aug 4, 2021
@bsian03 bsian03 merged commit 3d80d20 into abalabahaha:dev Aug 4, 2021
@Ashesh3 Ashesh3 deleted the patch-1 branch August 4, 2021 12:06
conorwastakenwastaken added a commit to conorwastakenwastaken/eris that referenced this pull request Sep 3, 2021
@conorwastakenwastaken
Squashed commit of the following:
ef632cf 
commit daedb2b
Author: Donovan Daniels <[email protected]>
Date:   Thu Sep 2 16:40:24 2021 -0500

    Sticker Sending (abalabahaha#1252)

    Co-Authored-By: Catboy <[email protected]>
    Co-authored-by: bsian03 <[email protected]>

commit e357991
Author: 5antos <[email protected]>
Date:   Sun Aug 29 23:18:45 2021 +0100

    Enhancements for VoiceChannel join methods (abalabahaha#1195)

    Co-authored-by: Almeida <[email protected]>
    Co-authored-by: bsian03 <[email protected]>

commit 53da0d5
Author: HeadTriXz <[email protected]>
Date:   Sat Aug 21 22:47:13 2021 +0200

    Better types for events (abalabahaha#1242)

    Co-authored-by: HeadTriXz <[email protected]>

commit 5246da9
Author: abalabahaha <[email protected]>
Date:   Thu Aug 19 13:08:56 2021 +0000

    Bump dev version

commit 6331536
Author: NeTT <[email protected]>
Date:   Thu Aug 19 18:29:06 2021 +0530

    Pass user data with member in Message constructor (abalabahaha#1260)

    Prevents "User associated with Member not found"

commit a58cd69
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 13:55:33 2021 +0100

    Support per-guild avatars (abalabahaha#1219)

commit 21a3ce5
Author: Erin <[email protected]>
Date:   Thu Aug 19 08:40:54 2021 -0400

    Add decodeReasons to typings (abalabahaha#1250)

commit 120f917
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 13:05:33 2021 +0100

    Expose components (abalabahaha#1189)

    Co-authored-by: HeadTriXz <[email protected]>
    Co-authored-by: HeadTriXz <[email protected]>
    Co-authored-by: Tsumari <[email protected]>
    Co-authored-by: Catboi <[email protected]>

commit 1e95e62
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 12:48:23 2021 +0100

    Warn when invalid intent is supplied (abalabahaha#1261)

commit a7bff54
Author: iiFDCT <[email protected]>
Date:   Thu Aug 19 12:46:51 2021 +0100

    Use new permission, intent names (abalabahaha#1257)

commit c31685e
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 12:44:57 2021 +0100

    Improve v8 ratelimit handling (abalabahaha#1256)

commit 1e4d78a
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 12:28:14 2021 +0100

    Expose audit log events 83-85 (abalabahaha#1213)

    * Audit log types 83-85

    * Update the comment

commit 840227e
Author: bsian03 <[email protected]>
Date:   Thu Aug 19 12:19:02 2021 +0100

    Type guild features as actual values (abalabahaha#1212)

commit 4bb65f0
Author: Emad Abdullah <[email protected]>
Date:   Thu Aug 5 00:04:44 2021 +0300

    fix permissions: Value "undefined" is not int for editRole & createRole (abalabahaha#1249)

commit 756943d
Author: Donovan Daniels <[email protected]>
Date:   Wed Aug 4 15:58:35 2021 -0500

    Fix documentation for create/editRole (abalabahaha#1248)

commit 3d80d20
Author: Ashesh <[email protected]>
Date:   Wed Aug 4 15:10:37 2021 +0530

    Mark ClientOptions in Eris function as required (abalabahaha#1255)

commit ee960c0
Author: bsian03 <[email protected]>
Date:   Tue Jul 13 21:25:57 2021 +0100

    Fix possibly undefined member in voiceStateUpdate (abalabahaha#1217)

    Co-authored-by: Erin <[email protected]>

commit e194a71
Author: Khaaz <[email protected]>
Date:   Tue Jul 13 13:04:21 2021 +0200

    REST v8, Gateway v8 (abalabahaha#1038)

    Co-authored-by: macdja38 <[email protected]>
    Co-authored-by: bsian03 <[email protected]>
    Co-authored-by: abalabahaha <[email protected]>

commit 0726aae
Author: geg <[email protected]>
Date:   Tue Jul 13 06:35:08 2021 -0400

    Use embeds array in embed example (abalabahaha#1244)

commit 8e9a2b7
Author: Reinhardt <[email protected]>
Date:   Tue Jul 13 17:34:33 2021 +0700

    Support sending multiple embeds (abalabahaha#1239)

commit 7e55222
Author: bsian03 <[email protected]>
Date:   Mon Jul 12 18:25:00 2021 +0100

    Allow passing a plain object to permissionsOf (abalabahaha#1224)

    Co-authored by: curtisf <[email protected]>

commit 0abf61a
Author: bsian03 <[email protected]>
Date:   Sun Jul 11 12:14:44 2021 +0100

    Expose Guild#nsfwLevel, deprecate Guild#nsfw (abalabahaha#1207)

commit 11d21c9
Author: Avocado <[email protected]>
Date:   Wed Jul 7 02:20:21 2021 -0500

    Update Endpoints.js (abalabahaha#1241)

commit d4a49a6
Author: bsian03 <[email protected]>
Date:   Tue Jul 6 23:38:36 2021 +0100

    Document disconnecting members from vc better (abalabahaha#1202)

    * Update Member.js

    * Update Guild.js

    * Update Client.js

    * No idea how that happened

commit b483ff3
Author: iiFDCT <[email protected]>
Date:   Tue Jul 6 16:21:56 2021 +0100

    Update sticker properties (abalabahaha#1237)

    * Use `sticker_items`

    * Docs

    * Update docs

    * Deprecate `stickers`, use `sticker_items`

    * Add user to cache

    * Empty string

    * Use camelCase

    * Wrong func

    * Docs

    * Add back useless property

    * Pretend like this variable ever gets defined

    * Newlines

commit 15546c4
Author: bsian03 <[email protected]>
Date:   Mon Jul 5 22:53:50 2021 +0100

    Make purgeChannel use getMessages options (abalabahaha#1236)
bsian03 pushed a commit to bsian03/eris that referenced this pull request Oct 10, 2021
@Ashesh3 @bsian03
Mark ClientOptions in Eris function as required (abalabahaha#1255)
e6ab5e7
@abalabahaha abalabahaha added this to the 0.16.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsian03 bsian03 bsian03 approved these changes

Assignees
No one assigned
Labels
typings
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashesh3 @DonovanDMC @bsian03 @abalabahaha