Expose components #1189

bsian03 · 2021-04-22T13:18:35Z

discord/discord-api-docs#3007 discord/discord-api-docs#3200 https://discord.com/developers/docs/interactions/message-components

Adds support for components. Type 2 Style 5 opens an external URL, the rest of them sends an interaction request.

HeadTriXz · 2021-04-22T13:39:02Z

Replace componenets with components.

HeadTriXz

Docs are finally officially released, I suggested some changes and make sure to update the JSDocs.

index.d.ts

Co-authored-by: HeadTriXz <[email protected]>

DonovanDMC

Worked completely when I tested in my code

R3dlessX

Good Job !

index.d.ts

JustCat80

editWebhookMessage(webhookID, token, messageID, options) { if(!options.content && !options.embeds && !options.file) { return Promise.reject(new Error("No content, embeds or file")); }}

    In client should be changed to

editWebhookMessage(webhookID, token, messageID, options) { if(!options.content && !options.embeds && !options.components && !options.file) { return Promise.reject(new Error("No content, embeds, components, or file")); }}

bsian03 · 2021-06-27T08:19:25Z

No

JustCat80 · 2021-06-27T14:12:34Z

No

Why not?

bsian03 · 2021-06-27T14:19:25Z

Because you still do need one of the 3 existing to send a component

JustCat80 · 2021-06-27T18:54:34Z

Not when editing a message

…ents

curtisf

Checked your structures against the docs and ran locally, LGTM

* Allow Components only for editwebhookmessage * Changed flags back to file

…ents

curtisf

Matches docs (unless I'm absolutely blind)

bsian03 · 2021-08-04T21:08:44Z

My eyesight has worsened by double from 3 years ago so lol

DonovanDMC · 2021-08-17T23:53:28Z

lib/Client.js

@@ -1242,8 +1276,8 @@ class Client extends EventEmitter {
                };
            } else if(content.content !== undefined && typeof content.content !== "string") {
                content.content = "" + content.content;
-            } else if(content.content === undefined && !content.embed && !content.embeds && content.flags === undefined) {
-                return Promise.reject(new Error("No content, embeds or flags"));
+            } else if(content.content === undefined && !content.embed && !content.embeds && !content.components && content.flags === undefined) {


Suggested change

} else if(content.content === undefined && !content.embed && !content.embeds && !content.components && content.flags === undefined) {

} else if(content.content === undefined && !content.embed && (!content.embeds || content.embeds.length === 0) && (!content.components || content.components.length === 0) && content.flags === undefined) {

This should be added to avoid issues when people provide only an empty array.

I think we can remove the check, there's an API error anyway and it's getting rather long

The whole thing including for editMessage?

Yeah, both create and edit. Nowadays this error is more likely to throw because of a new Discord feature than actually missing content.

in my opinion, the error this provides looks and sounds a lot better than what Discord says, which is just extremely generic

Cannot send an empty message

Bring that up with discord then :-)

DonovanDMC · 2021-08-17T23:54:34Z

lib/Client.js

+        if(!options.content && !options.embeds && !options.components && !options.file) {
+            return Promise.reject(new Error("No content, embed, components, or file"));


Suggested change

if(!options.content && !options.embeds && !options.components && !options.file) {

return Promise.reject(new Error("No content, embed, components, or file"));

if(!options.content && (!options.embeds || options.embeds.length === 0) && (!options.components || options.components.length === 0) && !options.file) {

return Promise.reject(new Error("No content, embeds, components, or file"));

…ents

bsian03 · 2021-08-19T12:04:42Z

Will remove the message checks in another PR if someone else doesn't get to it

commit daedb2b Author: Donovan Daniels <[email protected]> Date: Thu Sep 2 16:40:24 2021 -0500 Sticker Sending (abalabahaha#1252) Co-Authored-By: Catboy <[email protected]> Co-authored-by: bsian03 <[email protected]> commit e357991 Author: 5antos <[email protected]> Date: Sun Aug 29 23:18:45 2021 +0100 Enhancements for VoiceChannel join methods (abalabahaha#1195) Co-authored-by: Almeida <[email protected]> Co-authored-by: bsian03 <[email protected]> commit 53da0d5 Author: HeadTriXz <[email protected]> Date: Sat Aug 21 22:47:13 2021 +0200 Better types for events (abalabahaha#1242) Co-authored-by: HeadTriXz <[email protected]> commit 5246da9 Author: abalabahaha <[email protected]> Date: Thu Aug 19 13:08:56 2021 +0000 Bump dev version commit 6331536 Author: NeTT <[email protected]> Date: Thu Aug 19 18:29:06 2021 +0530 Pass user data with member in Message constructor (abalabahaha#1260) Prevents "User associated with Member not found" commit a58cd69 Author: bsian03 <[email protected]> Date: Thu Aug 19 13:55:33 2021 +0100 Support per-guild avatars (abalabahaha#1219) commit 21a3ce5 Author: Erin <[email protected]> Date: Thu Aug 19 08:40:54 2021 -0400 Add decodeReasons to typings (abalabahaha#1250) commit 120f917 Author: bsian03 <[email protected]> Date: Thu Aug 19 13:05:33 2021 +0100 Expose components (abalabahaha#1189) Co-authored-by: HeadTriXz <[email protected]> Co-authored-by: HeadTriXz <[email protected]> Co-authored-by: Tsumari <[email protected]> Co-authored-by: Catboi <[email protected]> commit 1e95e62 Author: bsian03 <[email protected]> Date: Thu Aug 19 12:48:23 2021 +0100 Warn when invalid intent is supplied (abalabahaha#1261) commit a7bff54 Author: iiFDCT <[email protected]> Date: Thu Aug 19 12:46:51 2021 +0100 Use new permission, intent names (abalabahaha#1257) commit c31685e Author: bsian03 <[email protected]> Date: Thu Aug 19 12:44:57 2021 +0100 Improve v8 ratelimit handling (abalabahaha#1256) commit 1e4d78a Author: bsian03 <[email protected]> Date: Thu Aug 19 12:28:14 2021 +0100 Expose audit log events 83-85 (abalabahaha#1213) * Audit log types 83-85 * Update the comment commit 840227e Author: bsian03 <[email protected]> Date: Thu Aug 19 12:19:02 2021 +0100 Type guild features as actual values (abalabahaha#1212) commit 4bb65f0 Author: Emad Abdullah <[email protected]> Date: Thu Aug 5 00:04:44 2021 +0300 fix permissions: Value "undefined" is not int for editRole & createRole (abalabahaha#1249) commit 756943d Author: Donovan Daniels <[email protected]> Date: Wed Aug 4 15:58:35 2021 -0500 Fix documentation for create/editRole (abalabahaha#1248) commit 3d80d20 Author: Ashesh <[email protected]> Date: Wed Aug 4 15:10:37 2021 +0530 Mark ClientOptions in Eris function as required (abalabahaha#1255) commit ee960c0 Author: bsian03 <[email protected]> Date: Tue Jul 13 21:25:57 2021 +0100 Fix possibly undefined member in voiceStateUpdate (abalabahaha#1217) Co-authored-by: Erin <[email protected]> commit e194a71 Author: Khaaz <[email protected]> Date: Tue Jul 13 13:04:21 2021 +0200 REST v8, Gateway v8 (abalabahaha#1038) Co-authored-by: macdja38 <[email protected]> Co-authored-by: bsian03 <[email protected]> Co-authored-by: abalabahaha <[email protected]> commit 0726aae Author: geg <[email protected]> Date: Tue Jul 13 06:35:08 2021 -0400 Use embeds array in embed example (abalabahaha#1244) commit 8e9a2b7 Author: Reinhardt <[email protected]> Date: Tue Jul 13 17:34:33 2021 +0700 Support sending multiple embeds (abalabahaha#1239) commit 7e55222 Author: bsian03 <[email protected]> Date: Mon Jul 12 18:25:00 2021 +0100 Allow passing a plain object to permissionsOf (abalabahaha#1224) Co-authored by: curtisf <[email protected]> commit 0abf61a Author: bsian03 <[email protected]> Date: Sun Jul 11 12:14:44 2021 +0100 Expose Guild#nsfwLevel, deprecate Guild#nsfw (abalabahaha#1207) commit 11d21c9 Author: Avocado <[email protected]> Date: Wed Jul 7 02:20:21 2021 -0500 Update Endpoints.js (abalabahaha#1241) commit d4a49a6 Author: bsian03 <[email protected]> Date: Tue Jul 6 23:38:36 2021 +0100 Document disconnecting members from vc better (abalabahaha#1202) * Update Member.js * Update Guild.js * Update Client.js * No idea how that happened commit b483ff3 Author: iiFDCT <[email protected]> Date: Tue Jul 6 16:21:56 2021 +0100 Update sticker properties (abalabahaha#1237) * Use `sticker_items` * Docs * Update docs * Deprecate `stickers`, use `sticker_items` * Add user to cache * Empty string * Use camelCase * Wrong func * Docs * Add back useless property * Pretend like this variable ever gets defined * Newlines commit 15546c4 Author: bsian03 <[email protected]> Date: Mon Jul 5 22:53:50 2021 +0100 Make purgeChannel use getMessages options (abalabahaha#1236)

Co-authored-by: HeadTriXz <[email protected]> Co-authored-by: HeadTriXz <[email protected]> Co-authored-by: Tsumari <[email protected]> Co-authored-by: Catboi <[email protected]>

[EXPERIMENTAL] Expose components

183d81b

abalabahaha added the Discord label Apr 22, 2021

Componenets, yes

144aee5

Merge branch 'dev' into components

8dcb789

HeadTriXz suggested changes May 26, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

bsian03 commented May 27, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

index.d.ts Outdated Show resolved Hide resolved

bsian03 and others added 3 commits May 27, 2021 08:44

Type alias rename and fixes

52de81f

Co-authored-by: HeadTriXz <[email protected]>

JSDoc update

b70cccc

Type rename again

634d42f

bsian03 marked this pull request as ready for review May 27, 2021 07:59

bsian03 changed the title ~~[EXPERIMENTAL] Expose components~~ Expose components May 27, 2021

DetachHead mentioned this pull request May 27, 2021

Support message components #1208

Closed

DonovanDMC previously approved these changes May 27, 2021

View reviewed changes

R3dlessX previously approved these changes May 27, 2021

View reviewed changes

bsian03 dismissed stale reviews from R3dlessX and DonovanDMC via 8cd6395 May 27, 2021 16:06

HeadTriXz suggested changes May 27, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

bsian03 force-pushed the components branch from 8cd6395 to 634d42f Compare May 27, 2021 16:40

bsian03 added 3 commits May 31, 2021 18:37

Emoji object values are all partial

725fa70

Components are allowed in webhooks

24caeaf

Component type 3

0e8f5df

bsian03 marked this pull request as draft June 2, 2021 18:55

HeadTriXz suggested changes Jun 2, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

Whoops

85f5348

JustCat80 suggested changes Jun 27, 2021

View reviewed changes

DonovanDMC added a commit to DonovanDMC/eris that referenced this pull request Jul 3, 2021

add in abalabahaha#1189

77b9c4f

DonovanDMC previously approved these changes Jul 6, 2021

View reviewed changes

bsian03 marked this pull request as ready for review July 7, 2021 12:46

Merge branch 'dev' of https://github.com/abalabahaha/eris into compon…

a1fc1a4

…ents

bsian03 dismissed DonovanDMC’s stale review via a1fc1a4 July 7, 2021 12:49

bsian03 requested a review from curtisf July 7, 2021 12:50

curtisf previously approved these changes Jul 7, 2021

View reviewed changes

Allow components-only in editMessage (#13)

97376b2

bsian03 dismissed curtisf’s stale review via 97376b2 July 12, 2021 09:54

Allow components-only on editWebhookMessage (#14)

549e6e8

* Allow Components only for editwebhookmessage * Changed flags back to file

bsian03 requested a review from curtisf July 12, 2021 10:04

JustCat80 previously approved these changes Jul 12, 2021

View reviewed changes

Merge branch 'dev' of https://github.com/abalabahaha/eris into compon…

0c5c5b6

…ents

bsian03 dismissed JustCat80’s stale review via 0c5c5b6 July 13, 2021 20:24

DonovanDMC approved these changes Jul 15, 2021

View reviewed changes

JustCat80 mentioned this pull request Jul 24, 2021

Support Interactions #1210

Closed

JustCat80 approved these changes Jul 24, 2021

View reviewed changes

curtisf approved these changes Aug 4, 2021

View reviewed changes

conorwastakenwastaken approved these changes Aug 5, 2021

View reviewed changes

DonovanDMC suggested changes Aug 17, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'dev' of https://github.com/abalabahaha/eris into compon…

42f05d1

…ents

bsian03 merged commit 120f917 into abalabahaha:dev Aug 19, 2021

bsian03 deleted the components branch August 22, 2021 11:04

JustCat80 mentioned this pull request Oct 3, 2021

Support Interactions #1280

Merged

abalabahaha added this to the 0.16.0 milestone Nov 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose components #1189

Expose components #1189

bsian03 commented Apr 22, 2021 •

edited

Loading

HeadTriXz commented Apr 22, 2021

HeadTriXz left a comment

DonovanDMC left a comment

R3dlessX left a comment

JustCat80 left a comment •

edited

Loading

bsian03 commented Jun 27, 2021

JustCat80 commented Jun 27, 2021

bsian03 commented Jun 27, 2021

JustCat80 commented Jun 27, 2021

curtisf left a comment

curtisf left a comment

bsian03 commented Aug 4, 2021

DonovanDMC Aug 17, 2021

abalabahaha Aug 19, 2021

bsian03 Aug 19, 2021

abalabahaha Aug 19, 2021

DonovanDMC Aug 19, 2021

bsian03 Aug 19, 2021

DonovanDMC Aug 17, 2021

This comment has been minimized.

bsian03 commented Aug 19, 2021

	} else if(content.content === undefined && !content.embed && !content.embeds && !content.components && content.flags === undefined) {
	} else if(content.content === undefined && !content.embed && (!content.embeds \|\| content.embeds.length === 0) && (!content.components \|\| content.components.length === 0) && content.flags === undefined) {

		if(!options.content && !options.embeds && !options.components && !options.file) {
		return Promise.reject(new Error("No content, embed, components, or file"));

Expose components #1189

Expose components #1189

Conversation

bsian03 commented Apr 22, 2021 • edited Loading

HeadTriXz commented Apr 22, 2021

HeadTriXz left a comment

Choose a reason for hiding this comment

DonovanDMC left a comment

Choose a reason for hiding this comment

R3dlessX left a comment

Choose a reason for hiding this comment

JustCat80 left a comment • edited Loading

Choose a reason for hiding this comment

bsian03 commented Jun 27, 2021

JustCat80 commented Jun 27, 2021

bsian03 commented Jun 27, 2021

JustCat80 commented Jun 27, 2021

curtisf left a comment

Choose a reason for hiding this comment

curtisf left a comment

Choose a reason for hiding this comment

bsian03 commented Aug 4, 2021

DonovanDMC Aug 17, 2021

Choose a reason for hiding this comment

abalabahaha Aug 19, 2021

Choose a reason for hiding this comment

bsian03 Aug 19, 2021

Choose a reason for hiding this comment

abalabahaha Aug 19, 2021

Choose a reason for hiding this comment

DonovanDMC Aug 19, 2021

Choose a reason for hiding this comment

bsian03 Aug 19, 2021

Choose a reason for hiding this comment

DonovanDMC Aug 17, 2021

Choose a reason for hiding this comment

This comment has been minimized.

bsian03 commented Aug 19, 2021

bsian03 commented Apr 22, 2021 •

edited

Loading

JustCat80 left a comment •

edited

Loading