Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please disable whole card pass-through when raw disk image is specified #39

Closed
rokuyama opened this issue Aug 21, 2022 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@rokuyama
Copy link

For v1.0.6RC2, raw pass-through for the whole SD card is enabled when no disk image file is present, but raw disk image is explicitly specified in zuluscsi.ini, e.g.:

(snip)
[SCSI0]
IMG0 = RAW:2097152:35651583
(snip)

For this example, the whole card is recognized as SCSI1 if no image file is present. As a result, sectors between 2097152 to 35651583 can be accessed both as SCSI0 and SCSI1. This is dangerous behavior.

Therefore, I'd like to propose to disable the whole card pass-through when a raw disk image is explicitly specified in zuluscsi.ini, as done when a image file is present.

@PetteriAimonen
Copy link
Collaborator

This is a bug indeed. I will take a look at it next week.

As a workaround until this is fixed, adding a small dummy image file will disable the automatic fallback.

@PetteriAimonen PetteriAimonen self-assigned this Aug 21, 2022
@rokuyama
Copy link
Author

@PetteriAimonen Thank you for your attention!

As a workaround until this is fixed, adding a small dummy image file will disable the automatic fallback.

Thanks, this actually works around the problem.

@aperezbios
Copy link
Collaborator

@rokuyama thanks for the report, we will address this promptly and release new firmware, hopefully within a day or two. Since effectively all of our existing customer base is using image-based volumes, the severity of this bug is not as bad as it would otherwise be.

@aperezbios aperezbios added the bug Something isn't working label Aug 21, 2022
@rokuyama
Copy link
Author

@aperezbios Thank you always for your help! Please take your time. This should not be urgent. Also, I will be out during Tuesday to Sunday. I'm sorry in case I cannot test new firmware timely.

morio pushed a commit that referenced this issue Aug 25, 2022
Changed so that code properly checks for image specified through
any means, not just through filename lookup.
@aperezbios
Copy link
Collaborator

@rokuyama This is fixed with the release of firmware version 1.0.7. If you have any further issues once upgrading, let us know.

@rokuyama
Copy link
Author

I've confirmed that it has been fixed for firmware v1.0.7. Thank you very much for your kind support!

@aperezbios
Copy link
Collaborator

Great, thanks for the original report, @rokuyama :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants