Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #101

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Improvements #101

merged 3 commits into from
Dec 26, 2024

Conversation

chcmedeiros
Copy link
Collaborator

closes #96 #95

@chcmedeiros chcmedeiros force-pushed the improvements branch 2 times, most recently from ed53e16 to 14ca245 Compare December 23, 2024 17:55
emmanuelm41
emmanuelm41 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any ticket on the amounts... is that correct? Going from 25.0 to 25 makes it even worse...

@chcmedeiros
Copy link
Collaborator Author

I don't see any ticket on the amounts... is that correct? Going from 25.0 to 25 makes it even worse...

The token that is sent is represented with an address in "Sending token", it is not the most friendly ui indeed

@emmanuelm41
Copy link
Member

But isn't that considered blind signing? is it under expert mode? ok, if that is the case, it is ok not to have a ticket. Do we have a ticker on nam native tokens? The thing here is that we don actually know which is the magnitude of what you are transfer. Is it the minimal unit of a token? is it something else? Using the decimal representation, at least it shows it is not the smallest unit representation

@chcmedeiros
Copy link
Collaborator Author

But isn't that considered blind signing? is it under expert mode? ok, if that is the case, it is ok not to have a ticket. Do we have a ticker on nam native tokens? The thing here is that we don actually know which is the magnitude of what you are transfer. Is it the minimal unit of a token? is it something else? Using the decimal representation, at least it shows it is not the smallest unit representation

For the native token we print NAM instead of the token address. For the others we just print the address.
I agree with you regarding the use of the decimal representation. Let me take this to Murisi before we merge.

@chcmedeiros chcmedeiros merged commit c5c693f into dev Dec 26, 2024
28 checks passed
@chcmedeiros chcmedeiros deleted the improvements branch December 26, 2024 10:37
chcmedeiros added a commit that referenced this pull request Dec 26, 2024
@chcmedeiros
Merge pull request #102 from Zondax/dev
ddcbdac 
Improvements (#101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@neithanmo neithanmo neithanmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chcmedeiros @emmanuelm41 @neithanmo