You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes the Namada Ledger app prints out a redundant trailing .0 when printing out TxAmounts. For example 10.0 and 133.0 instead of just 10 and 133. More concretely, see attached test vectors that currently fail due to this .0 issue here: decimal_point_testvectors.json Though transaction displays are still correct with trailing .0s, this fractional part does not convey any information about the token denomination (since most of the zeros have already been stripped). Worse still, they complicate the test vector generation code a little since we need to exactly match Ledger app outputs for our CI to pass. Could these trailing .0s be removed?
I think the redundant zero (that is causing our mismatch) is left behind in the call at
Sometimes the Namada Ledger app prints out a redundant trailing
.0
when printing outTx
Amount
s. For example10.0
and133.0
instead of just10
and133
. More concretely, see attached test vectors that currently fail due to this.0
issue here: decimal_point_testvectors.json Though transaction displays are still correct with trailing.0
s, this fractional part does not convey any information about the token denomination (since most of the zeros have already been stripped). Worse still, they complicate the test vector generation code a little since we need to exactly match Ledger app outputs for our CI to pass. Could these trailing.0
s be removed?I think the redundant zero (that is causing our mismatch) is left behind in the call at
ledger-namada/app/src/parser_print_common.c
Line 164 in acb1d29
The text was updated successfully, but these errors were encountered: