Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking changes] - consolidate addresses to robust type - group fees data into tx itself #146

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Apr 7, 2024

  • add robust addresses consolidation process as optional
  • remove Fee rows, and make them part of the tx itself
  • update golem to latest version
  • use golem logger instead of zap

🔗 zboto Link

@emmanuelm41 emmanuelm41 force-pushed the feat/new-features branch 2 times, most recently from c51dc63 to c936c59 Compare April 7, 2024 19:35
@emmanuelm41 emmanuelm41 requested a review from lucaslopezf May 11, 2024 02:42
@emmanuelm41 emmanuelm41 changed the title Feat/new features [breaking changes] - consolidate addresses to robust type - extract fees data to tx itself May 11, 2024
@emmanuelm41 emmanuelm41 changed the title [breaking changes] - consolidate addresses to robust type - extract fees data to tx itself [breaking changes] - consolidate addresses to robust type - group fees data into tx itself May 11, 2024
lucaslopezf and others added 17 commits July 10, 2024 12:23
* Unified fees txs

* update tests

* change name

* comment test

* Update v1 parser

* tests
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
* make zcache ttl configurable

* make robust addresses consolidation process optional

* fix tests

* fix linter

* condense code into generic function

* cover a missing case for addresses robust consolidation process
* refactor fn to make it more generic

* refactor FeesData struct

* consolidate miner address to robust on fees data

* extract transaction fess calculation to function

* fix lint
Bumps [github.com/zondax/golem](https://github.com/zondax/golem) from 0.14.1 to 0.14.4.
- [Release notes](https://github.com/zondax/golem/releases)
- [Commits](Zondax/golem@v0.14.1...v0.14.4)

---
updated-dependencies:
- dependency-name: github.com/zondax/golem
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants