Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all addresses to robust format #109

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Consolidate all addresses to robust format #109

merged 10 commits into from
Feb 13, 2024

Conversation

lucaslopezf
Copy link
Contributor

@lucaslopezf lucaslopezf commented Feb 8, 2024 •
edited by zboto bot
Loading

🔗 zboto Link

@lucaslopezf lucaslopezf marked this pull request as ready for review February 8, 2024 13:17
emmanuelm41
emmanuelm41 requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important issue to review

actors/cache/impl/zcache.go Outdated Show resolved Hide resolved
actors/cache/impl/zcache.go Outdated Show resolved Hide resolved
@lucaslopezf lucaslopezf changed the title consolidate all addresses to robust format Consolidate all addresses to robust format Feb 12, 2024
emmanuelm41
emmanuelm41 reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

actors/cache/impl/zcache.go Outdated Show resolved Hide resolved
emmanuelm41
emmanuelm41 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments. I think this is ready to merge after reviewing these comments

actors/cache/impl/utils.go Outdated Show resolved Hide resolved
actors/cache/impl/zcache.go Show resolved Hide resolved
actors/cache/impl/zcache.go Outdated Show resolved Hide resolved
actors/power.go Show resolved Hide resolved
parser/v1/parser.go Outdated Show resolved Hide resolved
@lucaslopezf lucaslopezf merged commit e60ad69 into dev Feb 13, 2024
5 checks passed
@lucaslopezf lucaslopezf deleted the feat/consolidate-addresses branch February 13, 2024 12:20
emmanuelm41 pushed a commit that referenced this pull request Apr 3, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
b2f3f14 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Apr 7, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
f028c3d 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Apr 7, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
f34becc 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Apr 7, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
ea4afff 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Apr 7, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
5ba3495 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Apr 7, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
e34f728 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request May 10, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
b91438a 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Jul 2, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
0246e83 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
emmanuelm41 pushed a commit that referenced this pull request Aug 2, 2024
@lucaslopezf @emmanuelm41
Consolidate all addresses to robust format (#109)
f343314 
* consolidate all addresses to robust format

* Increase test timeout

* Consolidate robust address

* Tests

* Refactor on consolidate addresses

* more changes

* more changes

* More changes

* minor changes

* enhance ensurerobustAddress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaslopezf @emmanuelm41