Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(ci): Update CI to run tests with zcash/lightwalletd instead of adityapk00/lightwalletd #7307

Merged
merged 1 commit into from
Aug 9, 2023
Merged

change(ci): Update CI to run tests with zcash/lightwalletd instead of adityapk00/lightwalletd #7307

merged 1 commit into from
Aug 9, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Aug 8, 2023 •
edited
Loading

Motivation

adityapk00/lightwalletd does not include new code added by the ECC to support new functionality.

We want to switch to the ECC version to use its new features.

Closes #7292.

Solution

  • Update CI workflow to use zcash/lightwalletd repo instead of adityapk00/lightwalletd

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 added P-Low ❄️ C-testing Category: These are tests lightwalletd any work associated with lightwalletd labels Aug 8, 2023
@arya2 arya2 requested a review from a team as a code owner August 8, 2023 22:10
@arya2 arya2 self-assigned this Aug 8, 2023
@arya2 arya2 requested review from gustavovalverde and removed request for a team August 8, 2023 22:10
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Aug 8, 2023
@arya2 arya2 requested a review from oxarbitrage August 8, 2023 22:41
@arya2
Copy link
Contributor Author

arya2 commented Aug 8, 2023

Running lightwalletd full sync here: https://github.com/ZcashFoundation/zebra/actions/runs/5802686366

digital-gob

This comment was marked as off-topic.

Sign in to view

gustavovalverde
gustavovalverde approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with the correct account 😄 )

mergify bot added a commit that referenced this pull request Aug 9, 2023
@mergify
Merge of #7307
c9b02d0
@mergify mergify bot mentioned this pull request Aug 9, 2023
Closed
@mergify mergify bot merged commit a9a6c6a into main Aug 9, 2023
@mergify mergify bot deleted the ci-zcash-lwd branch August 9, 2023 10:01
This was referenced Aug 11, 2023
Closed
Merged
This was referenced Aug 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digital-gob digital-gob digital-gob approved these changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage

Assignees

@arya2 arya2

Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade lightwalletd used by Zebra
3 participants
@arya2 @gustavovalverde @digital-gob