Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lightwalletd used by Zebra #7292

Closed
Tracked by #6642
oxarbitrage opened this issue Jul 26, 2023 · 1 comment · Fixed by #7307
Closed
Tracked by #6642

Upgrade lightwalletd used by Zebra #7292

oxarbitrage opened this issue Jul 26, 2023 · 1 comment · Fixed by #7307
Assignees

Comments

@oxarbitrage
Copy link
Contributor

Currently Zebra uses https://github.com/adityapk00/lightwalletd for all the CI ligthwalletd tasks as can be seen in https://github.com/ZcashFoundation/zebra/blob/v1.1.0/.github/workflows/zcash-lightwalletd.yml#L61

This version does not include new code added by the ECC to support new functionality: https://github.com/zcash/lightwalletd

For example ChainMetadata was added to https://github.com/zcash/lightwalletd/blob/master/walletrpc/compact_formats.proto#L31 which is needed by #7278

I am not sure yet if we can just switch to the ECC version or if we need to request the new changes to be done to the adityapk00 version.

@arya2
Copy link
Contributor

arya2 commented Aug 8, 2023

I am not sure yet if we can just switch to the ECC version or if we need to request the new changes to be done to the adityapk00 version.

I think we should switch to the ECC version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants