Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(state): Refactor the structure of verified blocks #7025

Merged
merged 2 commits into from
Jun 21, 2023
Merged

change(state): Refactor the structure of verified blocks #7025

merged 2 commits into from
Jun 21, 2023

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jun 20, 2023 •
edited
Loading

Motivation & Solution

In preparation for issue #6912, this PR:

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow-Up Work

upbqdn added 2 commits June 20, 2023 22:32
@upbqdn
Refactor CheckpointVerifiedBlock
670729e 
This commit turns `CheckpointVerifiedBlock` into a wrapper of
`SemanticallyVerifiedBlock` since both structs have the same fields.
@upbqdn
Refactor ContextuallyVerifiedBlockWithTrees
f2e13b9 
This commit uses `SemanticallyVerifiedBlock` in
`ContextuallyVerifiedBlockWithTrees` instead of
`CheckpointVerifiedBlock`.
@upbqdn upbqdn added A-rust Area: Updates to Rust code P-Medium ⚡ A-state Area: State / database changes labels Jun 20, 2023
@upbqdn upbqdn self-assigned this Jun 20, 2023
@upbqdn upbqdn requested a review from a team as a code owner June 20, 2023 20:52
@upbqdn upbqdn requested review from dconnolly and removed request for a team June 20, 2023 20:52
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #7025 (f2e13b9) into main (56a7638) will decrease coverage by 0.06%.
The diff coverage is 94.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7025      +/-   ##
==========================================
- Coverage   77.47%   77.42%   -0.06%     
==========================================
  Files         310      310              
  Lines       41647    41665      +18     
==========================================
- Hits        32268    32259       -9     
- Misses       9379     9406      +27

This was referenced Jun 21, 2023
Merged
Merged
@oxarbitrage oxarbitrage self-requested a review June 21, 2023 13:48
oxarbitrage
oxarbitrage approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks really good.

mergify bot added a commit that referenced this pull request Jun 21, 2023
@mergify
Merge of #7025
bde4eb7
@mergify mergify bot mentioned this pull request Jun 21, 2023
Closed
@mergify mergify bot merged commit 006c2ae into main Jun 21, 2023
@mergify mergify bot deleted the refactor-ContextuallyVerifiedBlockWithTrees branch June 21, 2023 16:58
upbqdn added a commit that referenced this pull request Jun 21, 2023
@upbqdn
change(state): Refactor the structure of verified blocks (#7025)
be83dc5 
* Refactor `CheckpointVerifiedBlock`

This commit turns `CheckpointVerifiedBlock` into a wrapper of
`SemanticallyVerifiedBlock` since both structs have the same fields.

* Refactor `ContextuallyVerifiedBlockWithTrees`

This commit uses `SemanticallyVerifiedBlock` in
`ContextuallyVerifiedBlockWithTrees` instead of
`CheckpointVerifiedBlock`.
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@dconnolly dconnolly Awaiting requested review from dconnolly dconnolly is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@upbqdn upbqdn

Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upbqdn @oxarbitrage