-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(state): Use OrderedUtxo
in CheckpointVerifiedBlock
#6971
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6971 +/- ##
==========================================
+ Coverage 77.35% 77.40% +0.05%
==========================================
Files 310 310
Lines 41534 41542 +8
==========================================
+ Hits 32129 32157 +28
+ Misses 9405 9385 -20 |
OrderedUtxo
in CheckpointVerifiedBlock
OrderedUtxo
in CheckpointVerifiedBlock
The CI says "Some checks were not successful", but I didn't manage to find what's wrong. |
It's the testnet checkpoint job, due to ongoing testing on testnet. We can ignore these temporary failures. (I think they might be fixed by now, so feel free to restart that job if you want.) I use Refined GitHub to make the failed jobs sort at the top, it works in every browser I've tried except Firefox: |
Testnet jobs aren't required, so the PR will merge as soon as Alfredo approves it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks.
Motivation
After looking into #6912, I realized
CheckpointVerifiedBlock
andSemanticallyVerifiedBlock
are the same, except that the first containsUtxo
, and the secondOrderedUtxo
. This PR makesCheckpointVerifiedBlock
useOrderedUtxo
as well. This makes the block types the same, which will make the refactor ofContextuallyVerifiedBlockWithTrees
simpler sinceContextuallyVerifiedBlock
usesOrderedUtxo
as well.Solution
Use
OrderedUtxo
instead ofUtxo
inCheckpointVerifiedBlock
.Reviewer Checklist
Follow Up Work