fix(ci): Fix network parameter in continous-delivery.yml, and add network labels to GCP jobs

[teor2345]

Motivation

We want to add the Zcash network as a GCP label. We need to lowercase the network to do that.

This also fixes a workflow input handling bug in continous-delivery.yml, which made it impossible to correctly implement a network label in PR #5693.

Solution

• fix network parameter in continous-delivery.yml
• standardise network usage in zcashd-manual-deploy
• add Network as a label
• use lowercase network labels

This PR also fixes some shellcheck errors using search and replace, including scripts in the unchanged parts of these workflows.

Review

This is a routine change.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
• How do you know it works? Does it have tests?

[teor2345]

@gustavovalverde I'm not sure how to test continous-delivery.yml, are there instructions?

zcashd-manual-deploy.yml isn't so important to test, because it is not used right now.

[arya2]

I'm not sure how to test continous-delivery.yml

The workflow dispatch is available here if that helps.

[teor2345]

I'm not sure how to test continous-delivery.yml

The workflow dispatch is available here if that helps.

Thanks!

I started a manual run here:
https://github.com/ZcashFoundation/zebra/actions/runs/3536561823

But we also need to test the release trigger, and check the labels, and maybe the logs for the instances?

I'm not sure how to do any of that.

[teor2345]

Failed due to #5384 again.

[teor2345]

@gustavovalverde I get this warning when running the workflow, but I don't think I made any changes to that part of the workflow:

Deploy single instance
The "create_credentials_file" option is true, but the current GitHub workspace is empty. Did you forget to use "actions/checkout" before this step? If you do not intend to share authentication with future steps in this job, set "create_credentials_file" to false.

https://github.com/ZcashFoundation/zebra/actions/runs/3536561823

[arya2]

@gustavovalverde I get this warning when running the workflow, but I don't think I made any changes to that part of the workflow:

Thise seems to be normal, it says that for all runs going back at least ~6 months:

https://github.com/ZcashFoundation/zebra/actions/runs/2411825703

[arya2]

Looks good to me!

The "current GitHub workspace is empty" warning isn't new so I'm not worried about it.

Versioning and deploy-nodes were skipped in the manual run, but:

• versioning wasn't changed (except the comment)
• changes to deploy-nodes and zcashd-manual-deploy were tested in CI jobs